Computed head reset #1057
Merged
Computed head reset #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erimelowo
requested review from
ButterscotchV,
Eirenliel and
ImUrX
as code owners
Erimelowo
added
Type: Bug
|
this should be rebased onto main after #962 got merged |
ImUrX
approved these changes
Jul 31, 2024
ButterscotchV
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: waiting on preliminary feedback before doing an open beta
This PR adds a toggle to reset the HMD's pitch upon full reset.
It also allows other computed (non-hmd) trackers, such as vive trackers, to be Full Reset and Mounting Reset according to the identity quaternion when wearing them on the head (unrelated to the aforementioned toggle). TODO (?): use mounting reset to adjust instead of the identity quaternion.
Needs: SlimeVR/SolarXR-Protocol#142, #962
Closes: #628
Tracker unit tests currently fail idk why