Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing head tracker status #962

Merged
merged 12 commits into from
Jul 11, 2024
Merged

Add missing head tracker status #962

merged 12 commits into from
Jul 11, 2024

Conversation

ImUrX
Copy link
Member

@ImUrX ImUrX commented Mar 18, 2024 •
edited
Loading

  • adds isHmd flag in Tracker
  • make an error when there is available isHmd trackers and headTracker in main skeleton is null
  • require reset on all assigned trackers when the HumanSkeleton#headTracker has changed

@ImUrX ImUrX added Area: GUI Related to the GUI Type: Enhancement Adds or improves a feature Area: Server Related to the server labels Mar 18, 2024
@ImUrX ImUrX force-pushed the hmd-check-status branch from a8c3cc5 to 955979b Compare March 30, 2024 15:04
@ImUrX ImUrX marked this pull request as ready for review March 30, 2024 17:06
@ImUrX ImUrX added the Status: Blocked by other issue Progress cannot be made until linked issue is resolved label Mar 30, 2024
@ImUrX
Copy link
Member Author

ImUrX commented Mar 30, 2024

Haven't tested it yet!

@ImUrX
Copy link
Member Author

ImUrX commented Mar 31, 2024

i tested it and it seems to work, status system is a little finicky in the GUI side, sometimes packets are lost, it should be solved someday tbh

@ImUrX ImUrX removed the Status: Blocked by other issue Progress cannot be made until linked issue is resolved label Apr 7, 2024
@Erimelowo Erimelowo mentioned this pull request Jun 13, 2024
Merged
@ImUrX ImUrX requested a review from Erimelowo June 17, 2024 10:24
@ImUrX ImUrX requested a review from loucass003 as a code owner July 11, 2024 15:37
@ImUrX ImUrX merged commit d8695d3 into SlimeVR:main Jul 11, 2024
12 checks passed
@ImUrX ImUrX deleted the hmd-check-status branch July 11, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erimelowo Erimelowo Erimelowo approved these changes

@ButterscotchV ButterscotchV ButterscotchV approved these changes

@Eirenliel Eirenliel Awaiting requested review from Eirenliel Eirenliel is a code owner

@loucass003 loucass003 Awaiting requested review from loucass003 loucass003 is a code owner

Assignees
No one assigned
Labels
Area: GUI Related to the GUI Area: Server Related to the server Type: Enhancement Adds or improves a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ImUrX @ButterscotchV @Erimelowo