Change mounting position/rotation/direction to mounting orientation #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButterscotchV
added
Type: Bug
ButterscotchV
requested review from
Eirenliel,
Erimelowo and
ImUrX
as code owners
Erimelowo
approved these changes
Feb 13, 2024
ImUrX
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have super inconsistent wording regarding mounting as a different term is basically used in each usage... This just makes everything "mounting orientation" as that seems to be the best dictionary fit, what is used in the code, and idk I prefer it lol. The only usage of "mounting rotation" left would be in SolarXR in a single comment.