Fixes #1937 preventing displaying all products from catalog on deleted virtual category #2007
Conversation
…n deleted virtual category
| @@ -139,15 +139,21 @@ public function __toString(): string | |||
| public function getCategorySearchQuery($category, $excludedCategories = []): ?QueryInterface | |||
| { | |||
| $query = null; | |||
| $rootCategory = null; | |||
There was a problem hiding this comment.
I don't a reason to initialize that variable since it is systematically overwritten in your additional condition.
| if ($category->getIsVirtualCategory() && $category->getVirtualCategoryRoot() !== null | ||
| && !empty($category->getVirtualCategoryRoot())) { | ||
| $rootCategoryId = $category->getVirtualCategoryRoot(); | ||
| $rootCategory = $this->categoryFactory->create()->setStoreId($this->getStoreId())->load($rootCategoryId); | ||
| $catId = $rootCategory->getId(); | ||
| } | ||
| if ((bool) $category->getIsVirtualCategory() && $category->getIsActive() && isset($catId)) { |
There was a problem hiding this comment.
Not a fan of the approach since it integrates part of the logic of checking the existence of the root category in \Smile\ElasticsuiteVirtualCategory\Model\Rule::getVirtualRootCategory.
I would change the logic of \Smile\ElasticsuiteVirtualCategory\Model\Rule::getVirtualCategoryQuery so that it returns a null query if \Smile\ElasticsuiteVirtualCategory\Model\Rule::getVirtualRootCategory returns null and change this section of code in \Smile\ElasticsuiteVirtualCategory\Model\Rule::getCategorySearchQuery
with something like this :
if ($category->getIsActive()) {
if ((bool) $category->getIsVirtualCategory()) {
$query = $this->getVirtualCategoryQuery($category, $excludedCategories, $category->getData('virtual_category_root'));
}
if (!$query) {
if ($category->getId() {
$query = $this->getStandardCategoryQuery($category, $excludedCategories);
}
}
}
if ($query && $category->hasChildren()) {
$query = $this->addChildrenQueries($query, $category, $excludedCategories);
}
But it's not perfect, and still a bit more complex.
On an additional note, your fix will apply when visiting the virtual category, but won't have any effect on parent categories, so we might want to address the problem as a whole by looking at what would happen in \Smile\ElasticsuiteVirtualCategory\Model\Rule::addChildrenQueries
There was a problem hiding this comment.
Conclusion: we need to discuss this.
No description provided.