Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources.generic: don't unregister non-registered sources on drop #153

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

elinorbgr
Copy link
Member

No description provided.

@elinorbgr elinorbgr force-pushed the elinorbgr/generic-drop branch from 531aa78 to 2132f3a Compare September 25, 2023 12:39
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.47% ⚠️

Comparison is base (92b42b1) 86.85% compared to head (2132f3a) 86.38%.

❗ Current head 2132f3a differs from pull request most recent head a893e76. Consider uploading reports for the commit a893e76 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   86.85%   86.38%   -0.47%     
==========================================
  Files          14       13       -1     
  Lines        1818     1748      -70     
==========================================
- Hits         1579     1510      -69     
+ Misses        239      238       -1     
Flag Coverage Δ
macos-latest ?
ubuntu-latest 86.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/sources/generic.rs 75.42% <100.00%> (-0.21%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elinorbgr elinorbgr force-pushed the elinorbgr/generic-drop branch from 2132f3a to a893e76 Compare September 25, 2023 12:58
@elinorbgr elinorbgr merged commit 6a67e67 into master Sep 25, 2023
@elinorbgr elinorbgr deleted the elinorbgr/generic-drop branch September 25, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant