Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we can't deregister non-registered sources #154

Closed
notgull opened this issue Sep 25, 2023 · 1 comment
Closed

Make sure we can't deregister non-registered sources #154

notgull opened this issue Sep 25, 2023 · 1 comment

Comments

@notgull
Copy link
Member

notgull commented Sep 25, 2023

Calloop recently found a bug where it's possible to deregister a source by trying to register it twice. See Smithay/calloop#153 for more information.

I don't think async-io is affected by this bug, but we should add a test case to make sure.
notgull pushed a commit that referenced this issue Oct 11, 2023
@siqpush
tests: Add test for #154
3564317 
* Test to prevent double registration from unregistering source

* amending to clippy + fmt and windows borrow_mut rules

* moving to TcpListener

* new register instead of binding to same address
@notgull
Copy link
Member Author

notgull commented Oct 11, 2023

Closed in #161

@notgull notgull closed this as completed Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@notgull