Add update_keymap method that's called when server provides keymap
#299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ids1024
added a commit
to pop-os/xdg-shell-wrapper
that referenced
this pull request
Sep 19, 2022
Fix for #8, though due to #10, changes to the selected layout group aren't forwarded from the server. Requires Smithay/client-toolkit#299 and Smithay/smithay#750. I believe this results in unregistering the `wl_keyboard` and creating a new one. Having a way in smithay to alter the existing `wl_keyboard` may work better. The above PRs also have soundness issues due to the non-thread-safe ref-counting in xdgcommon, and how smithay/sctk assume they hold the only references.
This is meant to provide a way to address pop-os/xdg-shell-wrapper#8, in combination with Smithay/smithay#750. For soundness reasons, and to avoid allocating when unused (in most clients), this has an awkward API that provides a way to get the keymap as a string.
ids1024
force-pushed
the
update_keymap
branch
from
bd08558 to
0239d42
Compare
i509VCB
approved these changes
Oct 6, 2022
|
The API isn't great here, but I don't know if anything better is really possible. Otherwise this should work fine. (While I think Smithay/smithay#750 isn't quite right.) |
|
I don't see anything else that would need to be done, @ids1024 are you fine with this being merged or do you have some new idea to handle this. |
|
Merging it seems good to me, given it's useful to support and I can't really think of a better way to do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to provide a way to address
pop-os/xdg-shell-wrapper#8, in combination with Smithay/smithay#750.
This is currently potentially unsound due to the
unsafe impl Send for KeyboardData {}.xdg::Keymapuses non-thread-safe ref-counting, but sctk assumes it is only used from one thread. This is difficult to address.