input: Add a way to add a keyboard to the seat from an xkb::keymap
#750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ids1024
added a commit
to ids1024/client-toolkit
that referenced
this pull request
Sep 19, 2022
This is meant to provide a way to address pop-os/xdg-shell-wrapper#8, in combination with Smithay/smithay#750. This is currently potentially unsound due to the `unsafe impl Send for KeyboardData {}`. `xdg::Keymap` uses non-thread-safe ref-counting, but sctk assumes it is only used from one thread. This is difficult to address.
ids1024
added a commit
to pop-os/xdg-shell-wrapper
that referenced
this pull request
Sep 19, 2022
Fix for #8, though due to #10, changes to the selected layout group aren't forwarded from the server. Requires Smithay/client-toolkit#299 and Smithay/smithay#750. I believe this results in unregistering the `wl_keyboard` and creating a new one. Having a way in smithay to alter the existing `wl_keyboard` may work better. The above PRs also have soundness issues due to the non-thread-safe ref-counting in xdgcommon, and how smithay/sctk assume they hold the only references.
|
This is potentially unsound since |
This should provide a way to fix things like pop-os/xdg-shell-wrapper#8. Cosmic's panel is implemented as a compositor that hosts applets as clients. It should just pass through the same keymap that is provided by the host compositor, rather than trying to create one from any configuration. This could also be useful for the Wayland backend (Smithay#676), depending on use case. Then a compositor using the Wayland backend would respect the host compositors keymap settings, but for some testing it may be helpful to do otherwise. This cannot directly accept an `xkb::Keymap` due to how `Keymap` uses reference counting and is not thread safe. Or rather it could, but only by converting it to a string and back internally.
ids1024
force-pushed
the
add_keyboard_from_keymap
branch
from
80a4227 to
bb01e4c
Compare
ids1024
added a commit
to ids1024/client-toolkit
that referenced
this pull request
Sep 23, 2022
This is meant to provide a way to address pop-os/xdg-shell-wrapper#8, in combination with Smithay/smithay#750. For soundness reasons, and to avoid allocating when unused (in most clients), this has an awkward API that provides a way to get the keymap as a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should provide a way to fix things like pop-os/xdg-shell-wrapper#8.
Cosmic's panel is implemented as a compositor that hosts applets as clients. It should just pass through the same keymap that is provided by the host compositor, rather than trying to create one from any configuration.
This could also be useful for the Wayland backend (#676), depending on use case. Then a compositor using the Wayland backend would respect the host compositors keymap settings, but for some testing it may be helpful to do otherwise.
Leaving this as a draft until I've tested it by incorporating it into xdg-shell-wrapper/cosmic-panel, and also making sure it passes through changes to the
groupcommunicated bywl_keyboard::modifiers.