Wrap DNS resolution in try/except (closes sopel-irc#2348)

SnoopJ · Mar 20, 2023 · a908184 · a908184
1 parent 8b098bf
commit a908184
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/sopel/modules/url.py b/sopel/modules/url.py
@@ -406,7 +406,12 @@ def process_urls(
             try:
                 ips = [ip_address(parsed_url.hostname)]
             except ValueError:
-                ips = [ip_address(ip) for ip in dns.resolver.resolve(parsed_url.hostname)]
+                # Extra try/except here in case the DNS resolution fails, see #2348
+                try:
+                    ips = [ip_address(ip) for ip in dns.resolver.resolve(parsed_url.hostname)]
+                except:
+                    LOGGER.debug("Cannot resolve hostname %s, ignoring URL %s", parsed_url.hostname, url, exc_info=True)
+                    continue
 
             private = False
             for ip in ips: