Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: Unexpected error on nonexistent domains #2348

Closed
dgw opened this issue Sep 9, 2022 · 2 comments · Fixed by #2285 or #2428
Closed

url: Unexpected error on nonexistent domains #2348

dgw opened this issue Sep 9, 2022 · 2 comments · Fixed by #2285 or #2428
Labels
Bug Things to squish; generally used for issues
Milestone

Comments

@dgw
Copy link
Member

dgw commented Sep 9, 2022

The following code line raises an unhandled dns.resolver.NXDOMAIN for URLs at nonexistent domains:

ips = [ip_address(ip) for ip in dns.resolver.resolve(parsed_url.hostname)]

Some variant of this operation has been in the code for a while, but the context has changed so much during 8.x that I decided not to follow git blame all the way back to the first addition of dns.resolver. Seemed like a waste of time.

@dgw dgw added the Bug Things to squish; generally used for issues label Sep 9, 2022
@dgw dgw added this to the 8.0.0 milestone Sep 9, 2022
@dgw
Copy link
Member Author

dgw commented Sep 9, 2022

I created this just to track it, but didn't dive into the code yet. Might be good that I didn't spend any more time because #2285 might just get rid of the cause entirely.

@SnoopJ
Copy link
Contributor

SnoopJ commented Mar 20, 2023

Stumbled into a decent reproducer for this error: a message that contains a URL terminated by a backtick `, e.g.

09:52 <+SnoopJ> does it happen for `hypothetical_language_variable = https://github.com` too
09:52 <+Sopel> Unexpected NXDOMAIN (The DNS query name does not exist: github.com`.) from SnoopJ at 2023-03-20 13:52:13.198849. Message was: does it happen for `hypothetical_language_variable = https://github.com` too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Things to squish; generally used for issues
Projects
None yet
2 participants