url: Wrap DNS resolution in try/except #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Exirel
requested changes
Mar 20, 2023
dgw
reviewed
Mar 20, 2023
dgw
changed the title
dgw
approved these changes
Mar 20, 2023
Co-authored-by: dgw <dgw@technobabbl.es> Co-authored-by: Florian Strzelecki <florian.strzelecki@gmail.com>
SnoopJ
force-pushed
the
bugfix/gh2348_cautious-DNS-resolution
branch
from
e81ff6a
to
a37f88a
Compare
Exirel
approved these changes
Mar 22, 2023
dgw
added
the
Bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changeset adds a bit of caution to the DNS resolution that might happen in the
[url]plugin, to fix #2348Checklist
make qa(runsmake qualityandmake test)1370 passed, 8 xfailed, 1 warning in 52.60s