forked from brooklyn-data/dbt_artifacts
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade/2.6.2 #2
Open
svenrudolph
wants to merge
37
commits into
main
Choose a base branch
from
upgrade/2.6.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md - Removed backticks and one parenthesis
Related to brooklyn-data#316, this change fixes another occurrence, this time for `invocations.invocation_args`. As DBT variables can contain single quotes, they must be escaped.
parse_json({{ field }}, wide_number_mode=>'round') was added for the …
…ne-bigquery-executions Escape newline for BQ execution messages
* Use safe.parse_json instead of parse_json * Replace hard-coded parse_json with macro
* Update version numbers * Update PR template
* Add CI checks for 1.6 * Add databricks tests * Specify linter version * Remove databricks
* Add CI checks for 1.6 * Add databricks tests * Specify linter version * Remove databricks * Fix main lint
Co-authored-by: Gemma Down <52132406+glsdown@users.noreply.github.com>
…data#382) * Add ability to exclude all results column * Add documentation about the variable
* Add named columns * Remove unused `rows_affected` column in `test_executions` brooklyn-data#195 * Reorganise macro folder * Add documentation for macros * Consolidate logic in upload results * Simplify how nodes are extracted * Generalise identifying objects to load further * Have all results included in the loop * Split out get_dataset_content * Move the get table content into its own macro * Bug fixing * Move relation definition to insert macro to avoid quoting issues * Revert "Remove unused `rows_affected` column in `test_executions` brooklyn-data#195" This reverts commit 9182fdc. * Remove ---debug left in databricks tox * Apply suggestions from code review Co-authored-by: Jared Rimmer <100997264+jared-rimmer@users.noreply.github.com> --------- Co-authored-by: Jared Rimmer <100997264+jared-rimmer@users.noreply.github.com>
… if loops (brooklyn-data#386) * add else clause to for if loops * Refactor logic for timestamp values Refactor logic to evaluate compile_started_at and query_completed_at values. * Refactor logic for timestamp values for all macros * Update macros/upload_individual_datasets/upload_model_executions.sql * Fix issue with `.get` usage --------- Co-authored-by: Jonathan Sellar <jonathan.sellar@health.govt.nz> Co-authored-by: Gemma Down <52132406+glsdown@users.noreply.github.com> Co-authored-by: Gemma Down <gemma.down@brooklyndata.co>
* Add macros for postgres * Add steps for postgres * Add postgres entry * Add a postgres service to action * Just test postgres for now * Fix duplicate section * Install correct package * Update host to localhost * Update profiles.yml to env vars * Add postgres env vars to step * Try again * Remove parse_json func * Another fix * Another fix * Alias the subquery * Add back other CDW [skip-ci] * Add postgres as supported DW [skip ci] * Test removing env vars * Another test * Add back DWs * Add missing CI tests * Formatting * Update to include new features --------- Co-authored-by: Gemma Down <gemma.down@brooklyndata.co>
* Minor tidy up * Simplifying timing extract
* Add support for 1.7 * Bump version number
Fix: typo in upload_results to determine batch size
…-from-model [Bug] Leave model intact when uploading
svenrudolph
had a problem deploying
to
Approve Integration Tests
April 10, 2024 13:15 — with
GitHub Actions
Failure
svenrudolph
had a problem deploying
to
Approve Integration Tests
April 10, 2024 13:15 — with
GitHub Actions
Failure
svenrudolph
had a problem deploying
to
Approve Integration Tests
April 10, 2024 13:15 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update type - breaking / non-breaking
What does this solve?
Outstanding questions
What databases have you tested with?