Update polkadot dependencies #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipstanislaus
approved these changes
Jun 23, 2021
Comment on lines
+333
to
+334
| // We don't track any teleports. | ||
| () |
There was a problem hiding this comment.
What is the reasoning behind that?
There was a problem hiding this comment.
By design, we don't support teleportation. Only reserve-backed transfers, which doesn't require trust in the other chain.
| type IsReserve = NativeAsset; | ||
| type IsTeleporter = (); | ||
| type IsTeleporter = NativeAsset; // <- should be enough to allow teleportation of ROC |
There was a problem hiding this comment.
Here we support teleportation though?
There was a problem hiding this comment.
Good catch, will fix!
| type Barrier = Barrier; | ||
| type Weigher = FixedWeightBounds<UnitWeightCost, Call>; | ||
| type Trader = UsingComponents<IdentityFee<Balance>, RococoLocation, AccountId, Balances, ()>; | ||
| type ResponseHandler = (); // Don't handle responses for now. |
There was a problem hiding this comment.
What's the reason for this?
There was a problem hiding this comment.
No idea. 😅
XCM documentation is sparse and a lot of the new XCM code I copy-pasted from the Cumulus parachains at https://github.com/paritytech/cumulus/tree/master/polkadot-parachains (statemint, rococo examples, etc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Polkadot/Cumulus dependencies to polkadot v0.9.4. This also required us to update GSRPC to get metadata V13 changes.
Note that XCM verification & testing is pushed out to a follow-up PR given the scope-creep that has arisen so far.
E2E tests mostly pass. For the tests that fail, there is an unrelated & pre-existing issue in the commitment relayer which results in some commitments getting ignored and are not being passed on to Ethereum.
Changes:
transferpallet. We no longer need a custom pallet to allow users to initiate XCM transfers.