Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offchain RPC methods should not SCALE-encode keys & values #171

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

vgeddes
Copy link
Contributor

@vgeddes vgeddes commented Jun 22, 2021

The Offchain DB should be treated as a generic key-value store, taking raw bytes for keys & values. The current implementation prevents us from reading values for arbitrary keys.

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #171 (3fe6e43) into master (db7f2af) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   58.51%   58.52%           
=======================================
  Files          98       98           
  Lines        3611     3602    -9     
=======================================
- Hits         2113     2108    -5     
+ Misses       1081     1079    -2     
+ Partials      417      415    -2     
Impacted Files Coverage Δ
rpc/offchain/get_local_storage.go 62.50% <100.00%> (+10.50%) ⬆️
rpc/author/submit_and_watch_extrinsic.go 72.22% <0.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db7f2af...3fe6e43. Read the comment docs.

Copy link
Contributor

@vedhavyas vedhavyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@vedhavyas
Copy link
Contributor

@vedhavyas vedhavyas merged commit 4fec3b3 into centrifuge:master Jun 22, 2021
tolak pushed a commit to Phala-Network/go-substrate-rpc-client that referenced this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants