Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SOL-43239] Enhance destination Wildcard Handling in SCSt Binder #3

Closed
Mrc0113 opened this issue Mar 28, 2020 · 2 comments · Fixed by #40
Closed

[SOL-43239] Enhance destination Wildcard Handling in SCSt Binder #3

Mrc0113 opened this issue Mar 28, 2020 · 2 comments · Fixed by #40
Labels
enhancement New feature or request tracked Internally tracked by Solace's internal issue tracking system
Milestone
SCSt 3.0.0

Comments

@Mrc0113
Copy link
Contributor

Mrc0113 commented Mar 28, 2020 •
edited
Loading

Consider enhancing how the destination field is treated when wildcards are in being used.
Maybe replace > or * with a different character that is valid in the queue name and apply the proper topic subscription to it

More info:
If I want to subscribe to pub/sub/plus I can do that successfully by specifying that as a destination in my bindings. However if I want to subscribe to pub/sub/plus/> I can no longer do that as > is not a valid character in a queue name. This forces me to specify a different destination name and then use the spring.cloud.stream.solace.bindings.<function-in-0>.consumer.queueAdditionalSubscriptions field to add the topic. This is inconvenient and can be confusing when ACLs come into play.
@Nephery Nephery added the enhancement New feature or request label Jul 8, 2020
@Nephery
Copy link
Collaborator

Nephery commented Nov 17, 2020

We should replace > and * with _. We can make it configurable in the future if we need to.

@Nephery Nephery added this to the SCSt 3.0.0 milestone Nov 17, 2020
@Nephery Nephery changed the title Enhance destination Wildcard Handling in SCSt Binder [SOL-43239] Enhance destination Wildcard Handling in SCSt Binder Nov 27, 2020
@Nephery Nephery added the tracked Internally tracked by Solace's internal issue tracking system label Nov 27, 2020
@GreenRover GreenRover mentioned this issue Dec 19, 2020
Merged
@Nephery Nephery linked a pull request Jan 15, 2021 that will close this issue
#35 topic wildcard handling #40
Merged
Nephery pushed a commit that referenced this issue Jan 15, 2021
@GreenRover
GH-3 Replace topic wild cards in queue name to avoid exceptions (#40)
c1ad273 
Co-authored-by: ue85540 <ue85540@sbb.ch>
@Nephery Nephery mentioned this issue Feb 24, 2021
Merged
Nephery added a commit that referenced this issue Feb 24, 2021
@Nephery
2.0.0 Release (#75)
e79d5ae 
### Global
* Major version bump to `2.0.0`
* Upgrade to `spring-cloud` `2020.0.1`
* Upgrade to `spring-boot` `2.4.3`
* Upgrade to `sol-jcsmp` `10.10.0`
* Upgrade to `sol-jms` `10.10.0`
* Fix Java 11 build (#38)
* Migrate CI from Travis to Github Actions
* Use Maven Failsafe plugin to run integration tests

### Solace Spring Cloud Stream Binder
* Major version bump to `3.0.0`
* Add Solace Spring Message Headers (#50)
  * Add `SolaceHeaders` and `SolaceBinderHeaders`
  * Bidirectionally map `SolaceHeaders` to JCSMP properties so message handlers can read/write Solace properties
* Renamed "Binder DMQ" to "Error Queue"
* Fix requeuing logic (#13)
  * requeuing is no longer supported for anonymous consumer groups (i.e. temporary queues) since these cannot be rebound.
* Add support for manual acknowledgments (#14)
* Removed the message discard error handling strategy from defined consumer groups. The new default for these will be requeuing.
* Add support for wildcard destinations (#3)
* add consumer config options to omit group name from the consumer group queue or error queue names (#28)
* add `errorQueueNameOverride` consumer config option to override the generated error queue name with a custom config-provided one. (#28)
* Add `headerExclusions` producer config option to exclude headers from published messages
* Add `nonserializableHeaderConvertToString ` producer config option to convert non-serializable headers to strings
* Override the default DMQ eligibility when publishing to be true (#9)
* Remove `solace_raw_message` error-channel message header in favor of `sourceData` header
* Fix JMS interoperability
* Fix `null` payload error handling (#54)
* Fix error handling failures (#36)
* Add `errorMsgDmqEligibility` consumer config option to override failed input messages' DMQ eligibility property when republishing to error queues
* Refactor default generated queue names to be more similar to Solace's shared subscriptions feature
* Fix asynchronous publishing exceptions to be sent to error channels (#34)
* Properly construct the `ErrorMessage` for publisher failures
* Configure client info provider to display Solace SCSt Binder release details
* Reduce warning levels from WARN to INFO when provisioning is disabled or when subscriptions already exist on queues
* Document ACL Profile tips when using error queues (#60)

### Solace Spring Cloud Connector
* Upgrade to `spring-cloud-connectors` `2.2.13.RELEASE` (version managed separately from spring cloud BOM)
@Nephery
Copy link
Collaborator

Nephery commented Feb 25, 2021

Closed with #75

@Nephery Nephery closed this as completed Feb 25, 2021
@Mrc0113 Mrc0113 mentioned this issue Mar 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tracked Internally tracked by Solace's internal issue tracking system
Projects
None yet
Milestone
SCSt 3.0.0
Development

Successfully merging a pull request may close this issue.

#35 topic wildcard handling
2 participants
@Mrc0113 @Nephery