-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#35 topic wildcard handling #40
#35 topic wildcard handling #40
Conversation
...m-binder-core/src/main/java/com/solace/spring/cloud/stream/binder/util/XMLMessageMapper.java
Outdated
Show resolved
Hide resolved
Thanks @GreenRover. I'll take a deeper look at this next year to consider for the upcoming 2.0.0 release. But here are my initial thoughts:
I think this a neat idea. My only concern about this, is that if somebody actually wanted a subscription called Instead, to resolve this conflict, this should be a configurable feature which the user can decide to use or not use. e.g. create a boolean producer/consumer binding config option named something along the lines of
Instead of creating a different header for each variable, It might be cleaner to create a single header called something like @Mrc0113 could I also get your thoughts on this when you're back next year? |
is not a valid part of a subscription. I choosed the <> because > is a solace wildcard |
https://docs.solace.com/PubSub-Basics/Wildcard-Charaters-Topic-Subs.htm So in this particular case, the |
I changed it to: "destinationVariables" |
Rebased to: "#37" waiting for it to be merged. |
@GreenRover could you split issue 2 into a separate PRs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs tests to ensure that everything that depends on queue names works with the substitution:
- Basic consumer group functionality
- Producer-side consumer group pre-provisioning (i.e.
requiredGroups
) - Additional topic subscriptions (i.e.
queueAdditionalSubscriptions
) - Error queue republishing
Also I suggest rebasing your changes onto the squashed commit in stage-2.0.0
(#37 has been merged):
git rebase --onto stage-2.0.0 HEAD~<commit_count>
|
Prep with new SNAPSHOT versions
Issue #3: Replace wildcards from topic name to _ in queue name