Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File RegEx rule #339

Merged
merged 1 commit into from
Dec 28, 2014
Merged

File RegEx rule #339

merged 1 commit into from
Dec 28, 2014

Conversation

guwirth
Copy link
Collaborator

@guwirth guwirth commented Dec 27, 2014

This rule template can be used to create rules which will be triggered when a file matches a given regular expression. Additional a Ant-style matching pattern for the path can be defined.

Also a solution for #179.

This rule template can be used to create rules which will be triggered when a file matches a given regular expression.
Additional a Ant-style matching pattern for the path can be defined.
@guwirth
Copy link
Collaborator Author

guwirth commented Dec 28, 2014

This is really a general search of a regex pattern in a file. The search for the include is only one example. So I would keep the name file regex.

I'm thinking about a second one which is searching only in a line: LineRegularExpressionCheck.

@guwirth
Copy link
Collaborator Author

guwirth commented Dec 28, 2014

The intension was to have two general ways to create rules: xpath and regex.

@wenns
Copy link
Contributor

wenns commented Dec 28, 2014

Oh I see. I missed this point.

@wenns
Copy link
Contributor

wenns commented Dec 28, 2014

Off topic: do you have more features in the queue? I'd like to call a feature freeze in the next days...

@guwirth
Copy link
Collaborator Author

guwirth commented Dec 28, 2014

No. The only two missing points for me were the possibility to create own rules with xpath and regex.

Other open point for me is to try out new unit test behavior. Not sure if current implementation fits our boost test usage. Here I'm waiting for your description to start testing.

Looking to bugs the important ones seems to be #226 and #49. Especially #49 becomes more and more important but I have still no idea how to solve it.

wenns added a commit that referenced this pull request Dec 28, 2014
@wenns wenns merged commit b5c34bd into SonarOpenCommunity:master Dec 28, 2014
@guwirth guwirth self-assigned this Jan 4, 2015
@guwirth
Copy link
Collaborator Author

guwirth commented Jan 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants