V0.9.2 release: remaining issues? #363

guwirth · 2015-01-05T08:35:19Z

Hello all, which points are remaining to finish the V0.9.2 release?

Created some filters to track V0.9.2 changes:

wenns · 2015-01-05T10:33:21Z

Besides polishing of already merged stuff (C compatibility etc.) I think it is fair to merge the reactor / multi module thing: its is already sitting very long in the queue and is requested by both Jorge and Bert. But thats the last feature I want to merge in the 0.9.2-cycle. Time to test in production, gentlemen.

BTW: I've drafted the release procedure: https://github.com/wenns/sonar-cxx/wiki/Release-Procedure.

guwirth · 2015-01-05T11:36:21Z

Tried to assign all issues to a milestone (0.9.2 or 0.9.3). Please correct if I did it wrong.

guwirth · 2015-01-05T12:55:39Z

@wenns Not possible to set assignee lcintrat and Zetten. Maybe you have to configure this for the repository.

wenns · 2015-01-05T13:34:03Z

Should work now

guwirth · 2015-01-05T18:58:59Z

POM is ready, contains all developers.

guwirth · 2015-01-05T19:00:01Z

All issues and pull requests are assigned to developers and milestones.

guwirth · 2015-01-05T19:02:28Z

@wenns will create this as draft in this issue or do you have it already?

compose a list of fixed bugs
compose a list of enhancements
don't forget to thank to the contributors

wenns · 2015-01-05T20:02:43Z

No I havent. Please focus on stuff which is actually relevant for users when you compose the lists.

jmecosta · 2015-01-06T11:30:48Z

started running in production code... so far no regressions..

guwirth · 2015-01-06T19:16:03Z

Below a first draft for 0.9.2 enhancements. Still not complete at least xunit and multi-module missing. Please verify. Will provide another list with bugfixes.

enhancements

preprocessor enhancements:
- improve rescan and parameter extraction of cascaded macros (Incomplete macro replacement rescanning #302, Improve preprocessor rescan #304)
- support expressions in includes (Preprocessor does not support preprocessor expressions in includes #227, Support preprocessor expressions in includes #312)
- support named variadic arguments (Unable to parse named variadic arguments #300, Issue #300: Fix parsing of named variable arguments. #301)
- support uin64 values (Preprocessor does not support uint64 #224, Extend preprocessor to support uint64 #308)
parser enhancements:
- improve parsing speed (Enable memoization to improve parsing speed. #299, Very slow performance of nested parenthesis #294, How can I find out whats going on #260)
- ignore C++ keywords in C files (sonar.cxx.cFilesPatterns) (Ignore C++ keywords when parsing C files. #291, Please let me know will this plugin analyse c language code #345, sonar.cxx.cFilesPatterns => sonar.cxx.c.suffixes.sources #353)
- support special meaning of token paste operator for GCC (GNU CPP: special meaning of token paste operator #214, Support special meaning of token paste operator for GCC #298)
- support Visual Studio inline assembler (support of MSVC __asm {} statement #262, Microsoft specific asm support #333, __asm assembly-instruction // without ; #340)
- support GCC case range extension (Support GCC case range extension. #235)
- support ISO C99 compound literals (Support C99 compound literals. #237)
- support ISO C99 designated initializers (Support C99 designed initializers. #236)
metrics enhancements:
- compute file and package dependencies (based on #include) ( Generate include dependencies. #232, Improve dependencies violations #292)
- add metrics to count documented and undocumented APIs (Missing "public documented API" measure #307, Add Public API metrics and violations #318, Handle bitfield declaration in public API visitor #338)
- add metric to count number of violations of each type (Add metrics to count number of violations of each type. #177)
rule enhancements:
- new rules to check for violations on cyclic package dependencies (Generate include dependencies. #232, Improve dependencies violations #292)
- new rule to check for undocumented API (Missing "public documented API" measure #307, Add Public API metrics and violations #318, Handle bitfield declaration in public API visitor #338)
- new rule FileRegularExpressionCheck: can be used to create rules which will be triggered when a file matches a given regular expression (File RegEx rule #339, Verify for precompiled header files #179)
- new rule LineRegularExpressionCheck: can be used to create rules which will be triggered when a line matches a given regular expression (Line RegEx rule #341, Verify for precompiled header files #179)
- new rule FileEncodingCheck: check if all characters of a file can be encoded with the predefined charset (Supported source file encodings #223, create file encoding check #328)
- new rule MissingIncludeFileCheck: generate a violation for missing include files (Rule: C++ Include File Not Found #52, Generate violation for each missing include file. #239)
- new rule SwitchLastCaseIsDefaultCheck: test that a switch statement has 'default' label and that the 'default' is the final case (Add rules for switch 'default' case; 'present' and 'is last' #320)
- XPathCheck, FileRegularExpressionCheck , LineRegularExpressionCheck: new option allows Ant-style patterns to match a path (Extend XPathCheck with path filter #335)
- UselessParenthesesCheck: ignores generic code now (Ignore generic code in useless parentheses check. #231)
- TooManyStatementsPerLineCheck: new option to allow case and break in one line (Allow one-line case: break; constructs. #230)
- TooLongLineCheck: add a tab width setting to compute the length of the line more accurate (Count TAB characters properly in TooLongLineCheck. #233)
- MagicNumberCheck: improve magic number detection - const variables are no more violations (Const declarations are detected as magic numbers when not inside a function #296, Bugfix/296 const declaration #332)
- Unsupported Code Checker Custom Rules: make import of invalid XML rule files more stable (prevent server from not starting in case of invalid xml #254)
- update Cppcheck messages for 1.67 release (Update rules and model #286, New rules for CppCheck and PC-lint #264)
- update PC-lint messages for 9.00l release candidate (New rules for CppCheck and PC-lint #264)
coverage enhancements:
- possibility to set coverage for source files without coverage report to zero to get more realistic Technical Debt values (sonar.cxx.coverage.forceZeroCoverage) (No line coverage for files, which are not in the coverage report #218, Enhancement/218 line coverage for all files #321)
- Bullseye coverage reports: support coverage data on top level (src tag without folder tag) (Bulleye coverage file is not parsed correctly #243, #243 import coverage from elelements outside folder nodes #250, #243 import coverage for files at top level #251)
- Bullseye coverage reports: make path handling more robust (Bullseye based coverage import reports 'cannot find the file ...' #273, #273 ensure reference paths are well terminated #277)
add SQALE model definitions for the built-in checks (Add SQALE model definitions for the built-in checks #199)

guwirth · 2015-01-06T19:36:29Z

bugfixes

Preprocessor does not support uint64 (Preprocessor does not support uint64 #224)
No meaningful error message if force-included file cannot be found (No meaningful error message if force-included file cannot be found #225)
Preprocessor does not support preprocessor expressions in includes (Preprocessor does not support preprocessor expressions in includes #227)
Bulleye coverage file is not parsed correctly (Bulleye coverage file is not parsed correctly #243)
Server crash after updating 'External rules definition' with 0.9.1 (Server crash after updating 'External rules definition' with 0.9.1 #253)
How can I find out whats going on (How can I find out whats going on #260)
Unit test results not displayed in widget (Unit test results not displayed in widget #263)
Bullseye based coverage import reports 'cannot find the file ...' (Bullseye based coverage import reports 'cannot find the file ...' #273)
Issues in digesting boost test results (Issues in digesting boost test results #276)
Very slow performance of nested parenthesis (Very slow performance of nested parenthesis #294)
Const declarations are detected as magic numbers when not inside a function (Const declarations are detected as magic numbers when not inside a function #296)
Unable to parse named variadic arguments (Unable to parse named variadic arguments #300)
Incomplete macro replacement rescanning (Incomplete macro replacement rescanning #302)
NPE in org.sonar.cxx.visitors.AbstractCxxPublicApiVisitor.visitMemberDeclarator (NPE in org.sonar.cxx.visitors.AbstractCxxPublicApiVisitor.visitMemberDeclarator #327)
Cannot feed Valgrind report (Cannot feed Valgrind report #336)

jmecosta · 2015-01-06T19:44:29Z

Looks very good

guwirth · 2015-01-06T19:47:34Z

Thanks ....

go to all contributors (in alphabetical order):

@Bertk
@guwirth
@jmecosta
@lcintrat
@Typz
@Zetten

... and all people which were active on the Issue Tracker!

wenns · 2015-01-06T20:02:12Z

Superb ;)

wenns · 2015-01-07T11:11:37Z

Have extended the integration test documentation by an use case mind map.
https://github.com/wenns/sonar-cxx/wiki/Integration-test-suite
Helps to reason about things like the roadmap.

wenns · 2015-01-07T13:26:22Z

I've transverred the text snippets above to:
https://github.com/wenns/sonar-cxx/releases/tag/untagged-5e671789177ba72fd86b
Please edit there if necessary

jmecosta · 2015-01-07T13:49:01Z

What is perform static code analysis?

On Wed, Jan 7, 2015, 15:26 Waleri Enns notifications@github.com wrote:

I've transverred the text snippets above to:

https://github.com/wenns/sonar-cxx/releases/tag/untagged-5e671789177ba72fd86b
Please edit there if necessary

—
Reply to this email directly or view it on GitHub
#363 (comment).

wenns · 2015-01-07T14:24:14Z

The checks from the repos c++ SonarQube and c++ SonarQube Common.

wenns · 2015-01-07T14:54:07Z

I think I spotted a performance regression:

Sensor CxxRatsSensor...
15:50:08.432 INFO  - Sensor CxxRatsSensor done: 1174 ms
15:50:08.432 INFO  - Sensor CxxXunitSensor...
15:50:09.503 INFO  - Sensor CxxXunitSensor done: 1071 ms
15:50:09.504 INFO  - Sensor CxxCoverageSensor...
15:50:13.196 INFO  - Sensor CxxCoverageSensor done: 3692 ms
15:50:13.197 INFO  - Sensor CxxCppCheckSensor...
15:50:14.322 INFO  - Sensor CxxCppCheckSensor done: 1125 ms
15:50:14.323 INFO  - Sensor CxxVeraxxSensor...
15:50:15.140 INFO  - Sensor CxxVeraxxSensor done: 817 ms
15:50:15.140 INFO  - Sensor CxxValgrindSensor...
15:50:15.950 INFO  - Sensor CxxValgrindSensor done: 810 ms

I had no reports configured: the sensors spent each 1 s. doing basically nothing. Pretty sure it wasnt like that before.

jmecosta · 2015-01-07T14:57:17Z

I can check this to.

wenns · 2015-01-08T13:00:07Z

Happens on big projects, was due to the replacement of the Ant-based implementation with something other. Will just revert this commit. Ant, welcome back.

jmecosta · 2015-01-08T14:03:40Z

interesting... i have good results
20:51:53.977 INFO - Sensor CxxXunitSensor done: 44 ms
20:51:53.977 INFO - Sensor CxxCoverageSensor...
20:51:53.996 INFO - Sensor CxxCoverageSensor done: 19 ms
20:51:53.996 INFO - Sensor CxxCppCheckSensor...
20:51:54.003 INFO - Sensor CxxCppCheckSensor done: 7 ms
20:51:54.003 INFO - Sensor CxxVeraxxSensor...
20:51:54.011 INFO - Sensor CxxVeraxxSensor done: 8 ms
20:51:54.011 INFO - Sensor CxxValgrindSensor...
20:51:54.018 INFO - Sensor CxxValgrindSensor done: 7 ms

C:\Tekla\BuildTools\sonar-runner
SonarQube Runner 2.3
Java 1.7.0_71 Oracle Corporation (64-bit)
Windows 8.1 6.3 amd64

wenns · 2015-01-13T23:33:49Z

The performance hit was really obvious. It can be clearly seen in the code. The implementation has tried every single path under the basedir against the pattern. This is just not very smart. Should have noticed it earlier.

wenns · 2015-01-14T00:51:42Z

Guys, what did your testing say? Do I have an OK for releasing the current HEAD?

jmecosta · 2015-01-14T06:12:40Z

I think so

On Wed, Jan 14, 2015, 02:51 Waleri Enns notifications@github.com wrote:

Guys, what did your testing say? Do I have an OK for releasing the current
HEAD?

—
Reply to this email directly or view it on GitHub
#363 (comment).

guwirth · 2015-01-14T08:56:55Z

for boost unit test only simple mode can be used currently, but for me it is ok to support this with V0.9.3
final test with version from yesterday open from my side (doing it today)

wenns · 2015-01-14T13:21:02Z

Ok. I'll wait for another day or two. My own test in production can be considered as successful. Found one preprocessor issue (fixed) and one minor grammar issue (deferred).

Zetten · 2015-01-14T14:18:50Z

The current HEAD (770abf8) looks good on my projects too - no unexpected changes in violations or metrics. Analysis seems very slightly quicker as well, but it could just be noise.

Due to my mixed-language modules I have to comment out the DependencyAnalyzer use in CxxSquidSensor, but everything else seems fine.

guwirth · 2015-01-14T18:45:32Z

Did a test with SQ 4.5.2 (test database), sonar-runner 2.4, cxx 0.9.2 on Windows 7 x64

we ignore parsing errors and are not using any AST based functions yet
used functionality is ok => release

Settings:

# required metadata
sonar.projectKey=xxx
sonar.projectName=yyy
sonar.projectVersion=1.2.3

# no test of multi-language or multi-module
sonar.language=c++

# path to source directories
sonar.sources=.
sonar.cxx.includeDirectories=.

# special cxx settings
sonar.cxx.errorRecoveryEnabled=true
sonar.cxx.coverage.forceZeroCoverage=true
sonar.cxx.xunit.provideDetails=false
sonar.cxx.forceIncludes=VS10Macros.h

sonar.cxx.suffixes.sources=.c,.cpp
sonar.cxx.suffixes.headers=.h,.hh,.hpp,.inl
sonar.exclusions=**/_*.*,**/*_i.*,**/*_p.*,**/*Test*/**,**/*Example*/**,**/*Demo*/**,**/resource.h,**/*_obsolete/**,**/*_deprecated/**

# paths to the reports
sonar.cxx.cppcheck.reportPath=reports/cppcheck.xml
sonar.cxx.other.reportPath=reports/cxx-*.xml
sonar.cxx.coverage.reportPath=reports/coverage-*.xml
sonar.cxx.xunit.xsltURL=boosttest-1.x-to-junit-1.0.xsl
sonar.cxx.xunit.reportPath=reports/*.test.boostd.exe.log.xml

Bertk · 2015-01-14T19:03:22Z

I guess there is an issue with XPathCheck (cxx.checks) and visitFile method. I get results only if the matchFilePattern is empty. I use xpathQuery = //IDENTIFIER[@tokenValue='OutputDebugString']
and when I use matchFilePattern= **/*.cpp nothing is detected. It works without the matchFilePattern. The file pattern support should be removed.
I used SQ 4.5.2, Windows 7 64bit, JDK 1.7.u71, sonar-runner 2.4
Beside this issue - everything looks OK.

guwirth · 2015-01-14T20:05:20Z

See description: /**/*.cpp - matches all .cpp files in all directories (you have to define the root directory '/')

wenns · 2015-01-14T20:45:27Z

Guys, its done: https://github.com/wenns/sonar-cxx/releases/tag/cxx-0.9.2
Finally.
Thanks A LOT to all of you.
It was a quite busy chrismas offtime...

jmecosta · 2015-01-15T06:21:55Z

Thanks everyone also for the new release :)

wenns · 2015-01-15T08:33:28Z

Almost forgotten: There is one last point in the release procedure checklist: "Tweet/Announce". Can you guys do that on your channels?

jmecosta · 2015-01-15T09:51:51Z

done, twitter and google+

guwirth added question waiting for answer labels Jan 5, 2015

guwirth added this to the M 0.9.2 milestone Jan 5, 2015

wenns closed this as completed Jan 14, 2015

guwirth removed the waiting for answer label Jul 22, 2015

V0.9.2 release: remaining issues? #363

V0.9.2 release: remaining issues? #363

Comments

guwirth commented Jan 5, 2015

wenns commented Jan 5, 2015

guwirth commented Jan 5, 2015

guwirth commented Jan 5, 2015

wenns commented Jan 5, 2015

guwirth commented Jan 5, 2015

guwirth commented Jan 5, 2015

guwirth commented Jan 5, 2015

wenns commented Jan 5, 2015

jmecosta commented Jan 6, 2015

guwirth commented Jan 6, 2015

enhancements

guwirth commented Jan 6, 2015

bugfixes

jmecosta commented Jan 6, 2015

guwirth commented Jan 6, 2015

Thanks ....

wenns commented Jan 6, 2015

wenns commented Jan 7, 2015

wenns commented Jan 7, 2015

jmecosta commented Jan 7, 2015

wenns commented Jan 7, 2015

wenns commented Jan 7, 2015

jmecosta commented Jan 7, 2015

wenns commented Jan 8, 2015

jmecosta commented Jan 8, 2015

wenns commented Jan 13, 2015

wenns commented Jan 14, 2015

jmecosta commented Jan 14, 2015

guwirth commented Jan 14, 2015

wenns commented Jan 14, 2015

Zetten commented Jan 14, 2015

guwirth commented Jan 14, 2015

Bertk commented Jan 14, 2015

guwirth commented Jan 14, 2015

wenns commented Jan 14, 2015

jmecosta commented Jan 15, 2015

wenns commented Jan 15, 2015

jmecosta commented Jan 15, 2015