Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create rule S6423: Always log failures in Azure Functions #960

Merged
merged 6 commits into from
May 31, 2022
Merged

Create rule S6423: Always log failures in Azure Functions #960

merged 6 commits into from
May 31, 2022

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

@andrei-epure-sonarsource andrei-epure-sonarsource changed the title Create rule S6423 Create rule S6423: Always log failures in Azure Functions Apr 21, 2022
@andrei-epure-sonarsource
address comments
378c658 
note that the ``++ ++` syntax was intended only when special characters are used
@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

mary-georgiou-sonarsource
mary-georgiou-sonarsource approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@mary-georgiou-sonarsource mary-georgiou-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrei-epure-sonarsource andrei-epure-sonarsource mentioned this pull request Apr 25, 2022
Closed
@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@martin-strecker-sonarsource martin-strecker-sonarsource mentioned this pull request May 16, 2022
Closed
@martin-strecker-sonarsource martin-strecker-sonarsource mentioned this pull request May 16, 2022
Merged
16 tasks
@andrei-epure-sonarsource @martin-strecker-sonarsource
Update rules/S6423/csharp/metadata.json
63354d1 
Co-authored-by: Martin Strecker <103252490+martin-strecker-sonarsource@users.noreply.github.com>
@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-tools'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarsource-next
Copy link

SonarQube Quality Gate for 'rspec-frontend'

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pavel-mikula-sonarsource pavel-mikula-sonarsource marked this pull request as ready for review May 31, 2022 15:14
@pavel-mikula-sonarsource pavel-mikula-sonarsource merged commit e88ba79 into master May 31, 2022
@pavel-mikula-sonarsource pavel-mikula-sonarsource deleted the rule/add-RSPEC-S6423 branch May 31, 2022 15:15
pierre-loup-tristant-sonarsource pushed a commit that referenced this pull request Jun 17, 2022
@github-actions @pierre-loup-tristant-sonarsource
Create rule S6423: Always log failures in Azure Functions (#960)
02600f6
@martin-strecker-sonarsource
Copy link
Contributor

@ganncamp Is this rule also violating the naming convention?

This rule doesn't follow the title-writing guidelines: X should [not] be Y

@ganncamp
Copy link

ganncamp commented Aug 1, 2022

Yep @martin-strecker-sonarsource!

@ganncamp
Copy link

ganncamp commented Aug 1, 2022

You can drop the 'be' though. Don't know where my head was

irina-batinic-sonarsource pushed a commit that referenced this pull request Dec 5, 2022
@github-actions @irina-batinic-sonarsource
Create rule S6423: Always log failures in Azure Functions (#960)
26706ef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-strecker-sonarsource martin-strecker-sonarsource martin-strecker-sonarsource requested changes

@mary-georgiou-sonarsource mary-georgiou-sonarsource mary-georgiou-sonarsource approved these changes

@andrei-epure-sonarsource andrei-epure-sonarsource andrei-epure-sonarsource approved these changes

Assignees

@andrei-epure-sonarsource andrei-epure-sonarsource

Labels
dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martin-strecker-sonarsource @ganncamp @andrei-epure-sonarsource @mary-georgiou-sonarsource @pavel-mikula-sonarsource