Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S6423: Always log failures in Azure Functions #960

Merged
merged 6 commits into from
May 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions rules/S6423/csharp/metadata.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"title": "Azure Functions should log all failures.",
"type": "CODE_SMELL",
"status": "ready",
"remediation": {
"func": "Constant\/Issue",
"constantCost": "5min"
},
"tags": [
mary-georgiou-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
"error-handling"
],
"defaultSeverity": "Major",
"ruleSpecification": "RSPEC-6423",
"sqKey": "S6423",
"scope": "Main",
"defaultQualityProfiles": [ ],
"quickfix": "unknown"
}
54 changes: 54 additions & 0 deletions rules/S6423/csharp/rule.adoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
Capturing and logging errors is critical to monitoring the health of your Azure Functions application.

Each `catch` block inside an Azure Function should log helpful details about the failure. Moreover, the logging should not be done at `Debug` or `Trace` level.

Consider using the built-in integration with Application Insights for better monitoring of your Application.

mary-georgiou-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
// If you want to factorize the description uncomment the following line and create the file.
//include::../description.adoc[]

== Noncompliant Code Example

[source,csharp]
----
[FunctionName("Foo")]
public static async Task<IActionResult> Run(
[HttpTrigger(AuthorizationLevel.Anonymous, "get", "post", Route = null)] HttpRequest req,
ILogger log)
{
try
{
// do stuff that can fail
}
catch (Exception ex)
{
// the failure is not logged at all OR is logged at DEBUG/TRACE level
}
}
----

== Compliant Solution

[source,csharp]
----
[FunctionName("Foo")]
public static async Task<IActionResult> Run(
[HttpTrigger(AuthorizationLevel.Anonymous, "get", "post", Route = null)] HttpRequest req,
ILogger log)
{
try
{
// do stuff that can fail
}
catch (Exception ex)
{
log.LogError("Give details that will help investigations", ex);
}
}
----

== See

* https://docs.microsoft.com/en-us/azure/azure-functions/functions-bindings-error-pages?tabs=csharp[Azure Functions error handling and retries]
* https://docs.microsoft.com/en-us/azure/azure-functions/functions-monitoring[Monitor Azure Functions]
* https://docs.microsoft.com/en-us/azure/azure-monitor/app/azure-functions-supported-features[Application Insights for Azure Functions supported features]
2 changes: 2 additions & 0 deletions rules/S6423/metadata.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
{
}