Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve utility analyzers' performance #6974

Closed
4 tasks
mary-georgiou-sonarsource opened this issue Mar 22, 2023 · 1 comment
Closed
4 tasks

Improve utility analyzers' performance #6974

mary-georgiou-sonarsource opened this issue Mar 22, 2023 · 1 comment
Assignees
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: Performance It takes too long.

Comments

@mary-georgiou-sonarsource
Copy link
Contributor

mary-georgiou-sonarsource commented Mar 22, 2023

After the fix in #6576 to avoid calling the Semantic model for each syntax tree, we noticed a small increase in analysis time after version 8.54 (see graphs below).

In order to fix this performance regression:

The generic trend line for all projects (left-most is the newest version):
image
Selected projects that were impacted:
image

@mary-georgiou-sonarsource
Copy link
Contributor Author

mary-georgiou-sonarsource commented May 25, 2023

We decided not to proceed with the implementation of these issues for now as they are not really solving the regression introduced by #6576 (the performance investigations showed that they actually increased the regression).

Why? see this comment.

These issues will remain open as they are still valid hardening tickets for the Utility Base analyzers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: C# C# rules related issues. Area: VB.NET VB.NET rules related issues. Type: Performance It takes too long.
Projects
None yet
Development

No branches or pull requests

4 participants