Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable concurrent execution of the utility analyzers #7245

Conversation

csaba-sagi-sonarsource
Copy link
Contributor

Fixes #6674

I opted for ConcurrentBag as it had the best performance ( scenario: multiple threads writing, and a single consumer writing to disk after the threads finished their job).
Results of the benchmark:

ConcurrentStack | ConcurrentQueue | SynchronizedStream | ConcurrentBag
455.93 ms | 438.83 ms | 327.23 ms | 221.9 ms

@csaba-sagi-sonarsource csaba-sagi-sonarsource changed the base branch from master to feature/utility-analyzers May 22, 2023 11:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@csaba-sagi-sonarsource csaba-sagi-sonarsource marked this pull request as draft May 23, 2023 07:49
@csaba-sagi-sonarsource
Copy link
Contributor Author

It is a draft, as I did not yet have time to check if enabling concurrent execution actually improved the performance or not.

@costin-zaharia-sonarsource
Copy link
Member

costin-zaharia-sonarsource commented May 24, 2023

This will increase the thread contention even more, accentuating the problems were not facing. This needs to be measured on projects of different sizes and only after that take a decision.

@mary-georgiou-sonarsource
Copy link
Contributor

Closing this PR for now - its goal was to fix the performance introduced (see here) but it did not really help. As the issue connected to this PR still has value to improve performance, it should stay in the backlog and be handled in a future sprint.

@gregory-paidis-sonarsource gregory-paidis-sonarsource deleted the čaba/enable-concurrent-execution branch October 10, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UtilityAnalyzer: EnableConcurrentExecution
3 participants