UtilityAnalyzer: Use RegisterCompilationStartAction #6576

martin-strecker-sonarsource · 2022-12-20T16:42:24Z

Fixes #6558

martin-strecker-sonarsource · 2022-12-20T18:02:35Z

cc @pavel-mikula-sonarsource as this may conflict with your AnalyzerContext refactoring.

costin-zaharia-sonarsource · 2022-12-21T08:26:02Z

Hi @martin-strecker-sonarsource. What was the observed change in analysis time?

martin-strecker-sonarsource · 2022-12-21T09:31:48Z

Unscientific comparison:

martin-strecker-sonarsource · 2022-12-21T11:21:05Z

Here is a comparison of an AnalyzerRunner.exe run for a single UtilityAnalyzer:

AnalyzerRunner.exe C:\Projects\sonar-dotnet\analyzers\packaging\binaries C:\Projects\DeepSast\CsvHelper\CsvHelper.sln /a TokenTypeAnalyzer

	Master	PR
Runtime	27s	13s
Allocations	1107 MB	948 MB
TokenTypeAnalyzer	24.1s	7.6s

Current master:

Pausing 5 seconds before starting analysis...
Running analyzers for CsvHelper(net6.0)
Running analyzers for CsvHelper(net5.0)
Running analyzers for CsvHelper(netstandard2.1)
Running analyzers for CsvHelper(netstandard2.0)
Running analyzers for CsvHelper(net47)
Running analyzers for CsvHelper(net45)
Running analyzers for CsvHelper.Tests
Running analyzers for _build
Running analyzers for CsvHelper.Performance
Running analyzers for CsvHelper.Website
Found 0 diagnostics in 27228ms (1161163400 bytes allocated)
Statistics for TokenTypeAnalyzer:
Concurrent:                     False
Execution time (ms):            24099,7547
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            10
Compilation Start Actions:      0
Compilation End Actions:        0
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         0
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Execution times (ms):
TokenTypeAnalyzer:   24100

This PR

Pausing 5 seconds before starting analysis...
Running analyzers for CsvHelper(net6.0)
Running analyzers for CsvHelper(net5.0)
Running analyzers for CsvHelper(netstandard2.1)
Running analyzers for CsvHelper(netstandard2.0)
Running analyzers for CsvHelper(net47)
Running analyzers for CsvHelper(net45)
Running analyzers for CsvHelper.Tests
Running analyzers for _build
Running analyzers for CsvHelper.Performance
Running analyzers for CsvHelper.Website
Found 0 diagnostics in 13211ms (994932760 bytes allocated)
Statistics for TokenTypeAnalyzer:
Concurrent:                     False
Execution time (ms):            7648,7773
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Execution times (ms):
TokenTypeAnalyzer:    7649

martin-strecker-sonarsource · 2022-12-21T11:34:17Z

For all utility analyzers

AnalyzerRunner\Debug\net7.0\publish\AnalyzerRunner.exe C:\Projects\sonar-dotnet\analyzers\packaging\binaries C:\Projects\DeepSast\CsvHelper\CsvHelper.sln /a TokenTypeAnalyzer /a SymbolReferenceAnalyzer /a MetricsAnalyzer /a CopyPasteTokenAnalyzer /a FileMetadataAnalyzer /a LogAnalyzer

	Master	PR	PR EnableConcurrentExecution
Runtime	75 s	18 s	20 s
Allocation	3.692 MB	1243 MB	1243 MB
CopyPasteTokenAnalyzer	0.892	0.940	1.005
FileMetadataAnalyzer	0.196	0.170	0.189
LogAnalyzer	0.167	0.158	0.174
MetricsAnalyzer	4.0	2.711	2.974
SymbolReferenceAnalyzer	59.9	2.325	2.555
TokenTypeAnalyzer	6.8	6.8	7.527

Master

Running analyzers for CsvHelper(net6.0)
Running analyzers for CsvHelper(net5.0)
Running analyzers for CsvHelper(netstandard2.1)
Running analyzers for CsvHelper(netstandard2.0)
Running analyzers for CsvHelper(net47)
Running analyzers for CsvHelper(net45)
Running analyzers for CsvHelper.Tests
Running analyzers for _build
Running analyzers for CsvHelper.Performance
Running analyzers for CsvHelper.Website
Found 0 diagnostics in 75016ms (3871965648 bytes allocated)
Statistics for CopyPasteTokenAnalyzer:
Concurrent:                     False
Execution time (ms):            892,2681
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            10
Compilation Start Actions:      0
Compilation End Actions:        0
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         0
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for FileMetadataAnalyzer:
Concurrent:                     False
Execution time (ms):            195,5788
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            10
Compilation Start Actions:      0
Compilation End Actions:        0
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         0
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for LogAnalyzer:
Concurrent:                     False
Execution time (ms):            166,5213
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            10
Compilation Start Actions:      0
Compilation End Actions:        0
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         0
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for MetricsAnalyzer:
Concurrent:                     False
Execution time (ms):            4008,6636
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            10
Compilation Start Actions:      0
Compilation End Actions:        0
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         0
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for SymbolReferenceAnalyzer:
Concurrent:                     False
Execution time (ms):            59912,6414
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            10
Compilation Start Actions:      0
Compilation End Actions:        0
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         0
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for TokenTypeAnalyzer:
Concurrent:                     False
Execution time (ms):            6826,2595
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            10
Compilation Start Actions:      0
Compilation End Actions:        0
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         0
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Execution times (ms):
CopyPasteTokenAnalyzer:      892
FileMetadataAnalyzer:        196
LogAnalyzer:                 167
MetricsAnalyzer:            4009
SymbolReferenceAnalyzer:   59913
TokenTypeAnalyzer:          6826

PR

Pausing 5 seconds before starting analysis...
Running analyzers for CsvHelper(net6.0)
Running analyzers for CsvHelper(net5.0)
Running analyzers for CsvHelper(netstandard2.1)
Running analyzers for CsvHelper(netstandard2.0)
Running analyzers for CsvHelper(net47)
Running analyzers for CsvHelper(net45)
Running analyzers for CsvHelper.Tests
Running analyzers for _build
Running analyzers for CsvHelper.Performance
Running analyzers for CsvHelper.Website
Found 0 diagnostics in 18708ms (1303553416 bytes allocated)
Statistics for CopyPasteTokenAnalyzer:
Concurrent:                     False
Execution time (ms):            940,4342
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for FileMetadataAnalyzer:
Concurrent:                     False
Execution time (ms):            169,9631
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for LogAnalyzer:
Concurrent:                     False
Execution time (ms):            158,0171
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for MetricsAnalyzer:
Concurrent:                     False
Execution time (ms):            2711,442
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for SymbolReferenceAnalyzer:
Concurrent:                     False
Execution time (ms):            2324,8239
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for TokenTypeAnalyzer:
Concurrent:                     False
Execution time (ms):            6799,581
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Execution times (ms):
CopyPasteTokenAnalyzer:      940
FileMetadataAnalyzer:        170
LogAnalyzer:                 158
MetricsAnalyzer:            2711
SymbolReferenceAnalyzer:    2325
TokenTypeAnalyzer:          6800

With EnableConcurrentExecution = true

Pausing 5 seconds before starting analysis...
Running analyzers for CsvHelper(net6.0)
Running analyzers for CsvHelper(net5.0)
Running analyzers for CsvHelper(netstandard2.1)
Running analyzers for CsvHelper(netstandard2.0)
Running analyzers for CsvHelper(net47)
Running analyzers for CsvHelper(net45)
Running analyzers for CsvHelper.Tests
Running analyzers for _build
Running analyzers for CsvHelper.Performance
Running analyzers for CsvHelper.Website
Found 0 diagnostics in 20391ms (1303991808 bytes allocated)
Statistics for CopyPasteTokenAnalyzer:
Concurrent:                     True
Execution time (ms):            1004,5332
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for FileMetadataAnalyzer:
Concurrent:                     True
Execution time (ms):            189,3969
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for LogAnalyzer:
Concurrent:                     True
Execution time (ms):            173,524
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for MetricsAnalyzer:
Concurrent:                     True
Execution time (ms):            2974,0859
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for SymbolReferenceAnalyzer:
Concurrent:                     True
Execution time (ms):            2554,513
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Statistics for TokenTypeAnalyzer:
Concurrent:                     True
Execution time (ms):            7526,5965
Code Block Actions:             0
Code Block Start Actions:       0
Code Block End Actions:         0
Compilation Actions:            0
Compilation Start Actions:      10
Compilation End Actions:        10
Operation Actions:              0
Operation Block Actions:        0
Operation Block Start Actions:  0
Operation Block End Actions:    0
Semantic Model Actions:         10
Symbol Actions:                 0
Symbol Start Actions:           0
Symbol End Actions:             0
Syntax Node Actions:            0
Syntax Tree Actions:            0
Additional File Actions:        0
Suppression Actions:            0
Execution times (ms):
CopyPasteTokenAnalyzer:     1005
FileMetadataAnalyzer:        189
LogAnalyzer:                 174
MetricsAnalyzer:            2974
SymbolReferenceAnalyzer:    2555
TokenTypeAnalyzer:          7527

costin-zaharia-sonarsource · 2022-12-21T11:46:27Z

Excellent. Thanks looks awesome!

analyzers/src/SonarAnalyzer.Common/Rules/Utilities/UtilityAnalyzerBase.cs

analyzers/tests/SonarAnalyzer.UnitTest/Rules/Utilities/FileMetadataAnalyzerTest.cs

martin-strecker-sonarsource · 2023-01-03T09:40:50Z

/azp run

azure-pipelines · 2023-01-03T09:41:01Z

Azure Pipelines successfully started running 1 pipeline(s).

pavel-mikula-sonarsource

Reviewed the code, without reviewing the UTs yet

analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarSematicModelReportingContext.cs

analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarCompilationStartAnalysisContext.cs

analyzers/src/SonarAnalyzer.Common/Rules/Utilities/UtilityAnalyzerBase.cs

analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarAnalysisContextBase.cs

pavel-mikula-sonarsource

The SonarAnalysisContextBase changes have to be reverted

analyzers/tests/SonarAnalyzer.UnitTest/Rules/Utilities/UtilityAnalyzerBaseTest.cs

pavel-mikula-sonarsource

Should be doable with ReadParameters(SonarCompilationStartAnalysisContext)

analyzers/src/SonarAnalyzer.Common/Rules/Utilities/UtilityAnalyzerBase.cs

analyzers/tests/SonarAnalyzer.UnitTest/AnalysisContext/SonarSematicModelReportingContextTest.cs

analyzers/tests/SonarAnalyzer.UnitTest/Rules/Utilities/UtilityAnalyzerBaseTest.cs

analyzers/src/SonarAnalyzer.Common/Rules/Utilities/UtilityAnalyzerBase.cs

analyzers/tests/SonarAnalyzer.UnitTest/Rules/Utilities/UtilityAnalyzerBaseTest.cs

pavel-mikula-sonarsource

Final polishing

.../SonarAnalyzer.UnitTest/AnalysisContext/SonarCompilationStartAnalysisContextTest.Register.cs

… explicit.

pavel-mikula-sonarsource

I noticed an issue with inheritnace. Should be easy to fix.

analyzers/src/SonarAnalyzer.Common/Rules/Utilities/UtilityAnalyzerBase.cs

analyzers/tests/SonarAnalyzer.UnitTest/AnalysisContext/SonarAnalysisContextTest.Register.cs

analyzers/src/SonarAnalyzer.Common/AnalysisContext/SonarSematicModelReportingContext.cs

sonarqubecloud · 2023-02-10T12:10:32Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarqubecloud · 2023-02-10T12:13:32Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

pavel-mikula-sonarsource

LGTM

On Akka.Net, I did not see any change in performance, see the semantic models are most likely cached as they are queried by different rules of the same analysis:
Before: 67. 65. 67
After: 62, 66, 69

martin-strecker-sonarsource requested a review from costin-zaharia-sonarsource December 20, 2022 18:01

martin-strecker-sonarsource marked this pull request as ready for review December 20, 2022 18:01

martin-strecker-sonarsource requested a review from pavel-mikula-sonarsource December 21, 2022 08:42

martin-strecker-sonarsource commented Dec 21, 2022

View reviewed changes

analyzers/src/SonarAnalyzer.Common/Rules/Utilities/UtilityAnalyzerBase.cs Outdated Show resolved Hide resolved

pavel-mikula-sonarsource requested changes Dec 23, 2022

View reviewed changes

martin-strecker-sonarsource force-pushed the Martin/UtilityAnalyzer_Registration branch from 7402be7 to d442636 Compare January 3, 2023 09:24

martin-strecker-sonarsource requested a review from pavel-mikula-sonarsource January 3, 2023 10:15

martin-strecker-sonarsource force-pushed the Martin/UtilityAnalyzer_Registration branch from f6ca28a to 75f8a25 Compare January 17, 2023 16:05

pavel-mikula-sonarsource requested changes Jan 23, 2023

View reviewed changes

martin-strecker-sonarsource requested a review from pavel-mikula-sonarsource January 23, 2023 20:41

pavel-mikula-sonarsource requested changes Jan 24, 2023

View reviewed changes

martin-strecker-sonarsource commented Jan 24, 2023

View reviewed changes

analyzers/tests/SonarAnalyzer.UnitTest/Rules/Utilities/UtilityAnalyzerBaseTest.cs Outdated Show resolved Hide resolved

martin-strecker-sonarsource requested a review from pavel-mikula-sonarsource January 24, 2023 10:50

pavel-mikula-sonarsource requested changes Jan 25, 2023

View reviewed changes

martin-strecker-sonarsource mentioned this pull request Jan 25, 2023

UtilityAnalyzer: EnableConcurrentExecution #6674

Open

martin-strecker-sonarsource requested a review from pavel-mikula-sonarsource January 31, 2023 17:15

pavel-mikula-sonarsource reviewed Feb 1, 2023

View reviewed changes

analyzers/src/SonarAnalyzer.Common/Rules/Utilities/UtilityAnalyzerBase.cs Outdated Show resolved Hide resolved

analyzers/tests/SonarAnalyzer.UnitTest/Rules/Utilities/UtilityAnalyzerBaseTest.cs Outdated Show resolved Hide resolved

SonarSource deleted a comment from martin-strecker-sonarsource Feb 1, 2023

pavel-mikula-sonarsource requested changes Feb 1, 2023

View reviewed changes

.../SonarAnalyzer.UnitTest/AnalysisContext/SonarCompilationStartAnalysisContextTest.Register.cs Outdated Show resolved Hide resolved

.../SonarAnalyzer.UnitTest/AnalysisContext/SonarCompilationStartAnalysisContextTest.Register.cs Outdated Show resolved Hide resolved

martin-strecker-sonarsource added 3 commits February 1, 2023 18:44

Use RegisterCompilationStartAction

490ee42

Remove redundant check

3c81804

Check for IsGenerated in test

085fb99

martin-strecker-sonarsource added 8 commits February 1, 2023 18:44

Use List instead of Stack for collecting.

c4b9e0f

Use base class for ShouldGenerateMetrics

0c129ae

Formatting

1ef09f2

Allow ReadParameters to be called from more registrations.

1476891

Add tests for Registrations in SonarCompilationStartAnalysisContext

b6f90a8

Use SonarSematicModelReportingContext as parameter type and pass tree…

d957c2d

… explicit.

Move tests to SonarAnalysisContextTest.Register.cs

9ac6322

Adopt tests to use a stub instead of the mock.

dacee9b

martin-strecker-sonarsource force-pushed the Martin/UtilityAnalyzer_Registration branch from 3ac7fbe to dacee9b Compare February 1, 2023 17:44

martin-strecker-sonarsource added 4 commits February 1, 2023 18:45

Fix date in header

1d7fcfc

Change param type to more derived

d2c4cc9

Test issue reporting.

0915e47

Add more reporting tests

8b91a49

martin-strecker-sonarsource requested a review from pavel-mikula-sonarsource February 6, 2023 10:21

pavel-mikula-sonarsource mentioned this pull request Feb 8, 2023

Move Tree from SonarReportingContextBase to SonarTreeReportingContextBase #6729

Closed

pavel-mikula-sonarsource requested changes Feb 8, 2023

View reviewed changes

PR feedback

ec2cddc

martin-strecker-sonarsource requested a review from pavel-mikula-sonarsource February 14, 2023 11:00

pavel-mikula-sonarsource approved these changes Feb 23, 2023

View reviewed changes

pavel-mikula-sonarsource merged commit bb07dd6 into master Feb 23, 2023

pavel-mikula-sonarsource deleted the Martin/UtilityAnalyzer_Registration branch February 23, 2023 07:40

pavel-mikula-sonarsource mentioned this pull request Feb 23, 2023

AnalysisWarningAnalyzer: Fix rebase conflict #6783

Merged

This was referenced Mar 22, 2023

Improve utility analyzers' performance #6974

Closed

Improve TokenTypeAnalyzerBase performance #6975

Closed

mary-georgiou-sonarsource mentioned this pull request May 25, 2023

Revert "UtilityAnalyzer: Use RegisterCompilationStartAction" #7262

Merged

martin-strecker-sonarsource mentioned this pull request Jun 12, 2023

UtilityAnalyzer: Roll back the reversal of #6576 and bring back RegisterSemanticModelAction #7368

Closed

csaba-sagi-sonarsource mentioned this pull request Jun 13, 2023

UtilityAnalyzer: Reduce lock contention in ShouldGenerateMetrics #7411

Closed

martin-strecker-sonarsource mentioned this pull request Nov 20, 2023

UtilityAnalyzer: Add RegisterSemanticModelAction() and tests #8380

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UtilityAnalyzer: Use RegisterCompilationStartAction #6576

UtilityAnalyzer: Use RegisterCompilationStartAction #6576

martin-strecker-sonarsource commented Dec 20, 2022

martin-strecker-sonarsource commented Dec 20, 2022

costin-zaharia-sonarsource commented Dec 21, 2022 •

edited

Loading

martin-strecker-sonarsource commented Dec 21, 2022

martin-strecker-sonarsource commented Dec 21, 2022 •

edited

Loading

martin-strecker-sonarsource commented Dec 21, 2022 •

edited

Loading

costin-zaharia-sonarsource commented Dec 21, 2022

martin-strecker-sonarsource commented Jan 3, 2023

azure-pipelines bot commented Jan 3, 2023

pavel-mikula-sonarsource left a comment

pavel-mikula-sonarsource left a comment

pavel-mikula-sonarsource left a comment

pavel-mikula-sonarsource left a comment

pavel-mikula-sonarsource left a comment •

edited

Loading

sonarqubecloud bot commented Feb 10, 2023

sonarqubecloud bot commented Feb 10, 2023

pavel-mikula-sonarsource left a comment

UtilityAnalyzer: Use RegisterCompilationStartAction #6576

UtilityAnalyzer: Use RegisterCompilationStartAction #6576

Conversation

martin-strecker-sonarsource commented Dec 20, 2022

martin-strecker-sonarsource commented Dec 20, 2022

costin-zaharia-sonarsource commented Dec 21, 2022 • edited Loading

martin-strecker-sonarsource commented Dec 21, 2022

martin-strecker-sonarsource commented Dec 21, 2022 • edited Loading

martin-strecker-sonarsource commented Dec 21, 2022 • edited Loading

costin-zaharia-sonarsource commented Dec 21, 2022

martin-strecker-sonarsource commented Jan 3, 2023

azure-pipelines bot commented Jan 3, 2023

pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

pavel-mikula-sonarsource left a comment • edited Loading

Choose a reason for hiding this comment

sonarqubecloud bot commented Feb 10, 2023

sonarqubecloud bot commented Feb 10, 2023

pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

costin-zaharia-sonarsource commented Dec 21, 2022 •

edited

Loading

martin-strecker-sonarsource commented Dec 21, 2022 •

edited

Loading

martin-strecker-sonarsource commented Dec 21, 2022 •

edited

Loading

pavel-mikula-sonarsource left a comment •

edited

Loading