Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SonarAnalyzer.UnitTest project target framewrok from net7.0 to net8.0 #8363

Closed
sebastien-marichal opened this issue Nov 15, 2023 · 6 comments
Labels
Type: Tooling Tools make us productive.

Comments

@sebastien-marichal
Copy link
Contributor

sebastien-marichal commented Nov 15, 2023

This migration needs to ensure that all Razor unit tests work as expected. We had issues in the past when starting to use .NET 8 preview, and those tests started failing.

@andrei-epure-sonarsource
Copy link
Contributor

andrei-epure-sonarsource commented Nov 15, 2023

Hey @sebastien-marichal - could you please sync with @costin-zaharia-sonarsource on what we want to do?

It seems that this ticket suggest removing the Net8.UnitTest, and this comment says that we should not remove it.

What is said inside an issue takes precedence over what is said only in a comment, but I'd still like a common understanding.

I would like to have a clear plan at squad level.

Thanks!

@costin-zaharia-sonarsource
Copy link
Member

costin-zaharia-sonarsource commented Nov 15, 2023

@andrei-epure-sonarsource, @sebastien-marichal

In my opinion, we should do the following:

@sebastien-marichal sebastien-marichal added the Type: Tooling Tools make us productive. label Nov 16, 2023
@costin-zaharia-sonarsource
Copy link
Member

Closing this as done.

@costin-zaharia-sonarsource
Copy link
Member

We still need to do the revert.

@pavel-mikula-sonarsource
Copy link
Contributor

@costin-zaharia-sonarsource Can we close this now?

@costin-zaharia-sonarsource
Copy link
Member

Yes 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Tooling Tools make us productive.
Projects
None yet
Development

No branches or pull requests

4 participants