Fix UTs caused by .NET 8 release by using specific nuget version #8362
Conversation
github-actions
bot
assigned sebastien-marichal and unassigned antonioaversa and sebastien-marichal
sebastien-marichal
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -64,7 +64,7 @@ public class UriShouldNotBeHardcodedTest | |||
|
|
|||
| [DataTestMethod] | |||
| [DataRow("2.0.4", "2.0.3", "2.1.1")] | |||
| [DataRow(Constants.NuGetLatestVersion, Constants.NuGetLatestVersion, Constants.NuGetLatestVersion)] | |||
There was a problem hiding this comment.
will you open a ticket to bring this back to NuGet Latest?
why: we keep LatestVersion to be aware if some API changes lead to our rules creating FPs or FNs (e.g. a deprecated attribute might be removed, so we won't raise anymore on net8 and we need to update the rule)
There was a problem hiding this comment.
I created the ticket #8363
The goal would be to revert this PR when changing the target framework of the UT project to net8.0
| @@ -150,7 +150,7 @@ public class SkipMigration : Migration | |||
|
|
|||
| protected override void Up(MigrationBuilder migrationBuilder) { } | |||
| } | |||
| }").AddReferences(EntityFrameworkCoreReferences(Constants.NuGetLatestVersion)).Verify(); | |||
There was a problem hiding this comment.
will you open a ticket to bring this back to NuGet Latest?
For example, will we still ignore migrations on Net 8?
There was a problem hiding this comment.
No we will revert this PR during the migration of UT project to net8.0
| @@ -76,7 +76,7 @@ public class PermissiveCorsTest | |||
| .Verify(); | |||
|
|
|||
| private static IEnumerable<MetadataReference> AdditionalReferences => | |||
| NuGetMetadataReference.MicrosoftNetHttpHeaders(Constants.NuGetLatestVersion) | |||
| NuGetMetadataReference.MicrosoftNetHttpHeaders("2.1.14") | |||
There was a problem hiding this comment.
will you open a ticket to bring this back to NuGet Latest?
why: we keep LatestVersion to be aware if some API changes lead to our rules creating FPs or FNs (e.g. a deprecated attribute might be removed, so we won't raise anymore on net8 and we need to update the rule)
|
Kudos, SonarCloud Quality Gate passed!
|
No description provided.