Add project with .Net 8 unit tests #8236

costin-zaharia-sonarsource · 2023-10-20T13:39:37Z

I've tested the coverage import with a separate PR that I had to remove. Here is how it looks on sonarcloud:

and this is the build: https://dev.azure.com/sonarsource/DotNetTeam%20Project/_build/results?buildId=79428

costin-zaharia-sonarsource · 2023-10-20T15:36:57Z

analyzers/tests/SonarAnalyzer.Net8.UnitTest/Rules/SelfAssignmentTest.cs

+ [TestMethod]
+ public void SelfAssignment() =>
+ builderCS.AddPaths("SelfAssignment.cs").WithOptions(ParseOptionsHelper.FromCSharp12).Verify();


This is just to demonstrate that we can add .Net 8 unit tests on this project.

costin-zaharia-sonarsource · 2023-10-20T15:43:17Z

azure-pipelines.yml

@@ -203,13 +209,19 @@ stages:

 - powershell: |
 cd analyzers
- & dotnet test -f $(FrameworkMoniker) -c $(BuildConfiguration) -l trx /p:AltCover=true,AltCoverForce=true,AltCoverVisibleBranches=true,AltCoverAssemblyFilter='Moq|Humanizer|AltCover|Microsoft.VisualStudio.TestPlatform.*|.*Test',AltCoverPathFilter='SonarAnalyzer\.CFG\\ShimLayer|SonarAnalyzer\.ShimLayer\.CodeGeneration',AltCoverAttributeFilter='ExcludeFromCodeCoverage',AltCoverReport=coverage/coverage.xml
+ if ("$(FrameworkMoniker)" -eq "net8.0-windows") {
+ & dotnet test "tests\SonarAnalyzer.Net8.UnitTest\SonarAnalyzer.Net8.UnitTest.csproj" -f $(FrameworkMoniker) -c $(BuildConfiguration) -l trx --results-directory $(UnitTestResultsPath) /p:AltCover=true,AltCoverForce=true,AltCoverVisibleBranches=true,AltCoverAssemblyFilter='Moq|Humanizer|AltCover|Microsoft.VisualStudio.TestPlatform.*|.*Test',AltCoverPathFilter='SonarAnalyzer\.CFG\\ShimLayer|SonarAnalyzer\.ShimLayer\.CodeGeneration',AltCoverAttributeFilter='ExcludeFromCodeCoverage',AltCoverReport=$(CoveragePath)/coverage.$(FrameworkMoniker).xml


When the target framework parameter is provided, all projects need to support that version. Since this is not possible with .net 8, we have to specify the project.

martin-strecker-sonarsource

I may miss context here, but I'm not sure if we should really do this. What is the future prospect of this change? Are we going to revert it or is this permanent? If we are going to revert it, how do we make sure the new UTs written here are easily movable to the main UT project when we revert? We need to keep a couple of things in sync to do so:

namespaces
global using

We also need some follow-up issues that describe how we want to evolve this solution in the future.

analyzers/tests/SonarAnalyzer.Net8.UnitTest/ReadMe.md

martin-strecker-sonarsource · 2023-10-23T07:55:46Z

analyzers/tests/SonarAnalyzer.Net8.UnitTest/SonarAnalyzer.Net8.UnitTest.csproj

+<Project Sdk="Microsoft.NET.Sdk">
+
+ <PropertyGroup>
+ <!-- `-windows` is required in order to be able to reference SonarAnalyzer.UnitTests -->


Suggested change

analyzers/tests/SonarAnalyzer.UnitTest/TestFramework/ParseOptionsHelper.cs

martin-strecker-sonarsource · 2023-10-23T08:03:41Z

azure-pipelines.yml

+ & dotnet test "tests\SonarAnalyzer.Net8.UnitTest\SonarAnalyzer.Net8.UnitTest.csproj" -f $(FrameworkMoniker) -c $(BuildConfiguration) -l trx --results-directory $(UnitTestResultsPath) /p:AltCover=true,AltCoverForce=true,AltCoverVisibleBranches=true,AltCoverAssemblyFilter='Moq|Humanizer|AltCover|Microsoft.VisualStudio.TestPlatform.*|.*Test',AltCoverPathFilter='SonarAnalyzer\.CFG\\ShimLayer|SonarAnalyzer\.ShimLayer\.CodeGeneration',AltCoverAttributeFilter='ExcludeFromCodeCoverage',AltCoverReport=$(CoveragePath)/coverage.$(FrameworkMoniker).xml
+ }
+ else
+ {
+ & dotnet test "tests\SonarAnalyzer.UnitTest\SonarAnalyzer.UnitTest.csproj" -f $(FrameworkMoniker) -c $(BuildConfiguration) -l trx --results-directory $(UnitTestResultsPath) /p:AltCover=true,AltCoverForce=true,AltCoverVisibleBranches=true,AltCoverAssemblyFilter='Moq|Humanizer|AltCover|Microsoft.VisualStudio.TestPlatform.*|.*Test',AltCoverPathFilter='SonarAnalyzer\.CFG\\ShimLayer|SonarAnalyzer\.ShimLayer\.CodeGeneration',AltCoverAttributeFilter='ExcludeFromCodeCoverage',AltCoverReport=$(CoveragePath)/coverage.xml


The two cmd lines only differ in the csproj and the "Report" parameters. Consider using a variable for the common parts.

martin-strecker-sonarsource · 2023-10-23T08:04:32Z

azure-pipelines.yml

+ if ("$(FrameworkMoniker)" -eq "net8.0-windows") {
+ & dotnet test "tests\SonarAnalyzer.Net8.UnitTest\SonarAnalyzer.Net8.UnitTest.csproj" -f $(FrameworkMoniker) -c $(BuildConfiguration) -l trx --results-directory $(UnitTestResultsPath) /p:AltCover=true,AltCoverForce=true,AltCoverVisibleBranches=true,AltCoverAssemblyFilter='Moq|Humanizer|AltCover|Microsoft.VisualStudio.TestPlatform.*|.*Test',AltCoverPathFilter='SonarAnalyzer\.CFG\\ShimLayer|SonarAnalyzer\.ShimLayer\.CodeGeneration',AltCoverAttributeFilter='ExcludeFromCodeCoverage',AltCoverReport=$(CoveragePath)/coverage.$(FrameworkMoniker).xml
+ }
+ else


We can also run the "normal" tests in .Net 8.

Suggested change

else

analyzers/tests/SonarAnalyzer.Net8.UnitTest/Rules/SelfAssignmentTest.cs

analyzers/tests/SonarAnalyzer.Net8.UnitTest/SonarAnalyzer.Net8.UnitTest.csproj

costin-zaharia-sonarsource · 2023-10-25T07:24:45Z

What is the future prospect of this change? Are we going to revert it or is this permanent?

Hi @martin-strecker-sonarsource, I've clearly mentioned in the readme file that this is a temporary change.

If we are going to revert it, how do we make sure the new UTs written here are easily movable to the main UT project when we revert?

In the same document I've mentioned that the plan is to extract the validation framework. There is no mention about a revert. The problem in the dotnet APIs appeared so many times that we might want to separate some of the tests until they change their design to not use nuget libraries.

This is a way to have progress until 14 November when the new version is released and depending on the fixes they do we might adapt.

sonarcloud · 2023-10-25T19:01:31Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarcloud · 2023-10-25T19:08:54Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

martin-strecker-sonarsource · 2023-10-26T07:15:05Z

Situation in VS without .Net 8 SDK support (non "preview"):

The solution loads and "normal" UTs are working
The .Net8.UnitTest project can not be build and these UTs are not executable (SonarAnalyzer.Net8.UnitTest: The current Visual Studio version does not support targeting .NET 8.0. Either target .NET 7.0 or lower, or use Visual Studio version 17.8 or higher)
On load, VS modifies the package.lock json of the .Net8.UnitTest project

martin-strecker-sonarsource

LGTM. See my last comment for the impact for non-preview VS devs.

costin-zaharia-sonarsource force-pushed the costin/net8-uts branch 7 times, most recently from 90692f3 to c25e5ba Compare October 20, 2023 15:12

costin-zaharia-sonarsource commented Oct 20, 2023

View reviewed changes

costin-zaharia-sonarsource force-pushed the costin/net8-uts branch from c25e5ba to 6831983 Compare October 20, 2023 15:37

costin-zaharia-sonarsource marked this pull request as ready for review October 20, 2023 15:37

costin-zaharia-sonarsource commented Oct 20, 2023

View reviewed changes

martin-strecker-sonarsource requested changes Oct 23, 2023

View reviewed changes

costin-zaharia-sonarsource closed this Oct 25, 2023

cristian-ambrosini-sonarsource mentioned this pull request Oct 25, 2023

Fix S107 FP: Don't raise on Zero-overhead member access methods #8254

Merged

costin-zaharia-sonarsource reopened this Oct 25, 2023

costin-zaharia-sonarsource and others added 8 commits October 25, 2023 20:40

Add project with .Net 8 unit tests

dbb8a35

Address comments

62802fa

Add azure-pipelines changes

3018b25

Fix errors in azure-pipeline.yml

de4b837

Azure-pipeline debug

997ea13

Remove background jobs for UT execution

1d0a6c7

Change back the namespace to Net8

1ee5d29

Update unit tests to use a parameter

0c2d013

costin-zaharia-sonarsource force-pushed the costin/net8-uts branch from 4184ac1 to 0c2d013 Compare October 25, 2023 18:51

costin-zaharia-sonarsource requested a review from martin-strecker-sonarsource October 25, 2023 19:11

martin-strecker-sonarsource approved these changes Oct 26, 2023

View reviewed changes

costin-zaharia-sonarsource merged commit 8f8e69a into master Oct 26, 2023
27 checks passed

costin-zaharia-sonarsource deleted the costin/net8-uts branch October 26, 2023 08:09

andrei-epure-sonarsource mentioned this pull request Nov 15, 2023

Migrate SonarAnalyzer.UnitTest project target framewrok from net7.0 to net8.0 #8363

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add project with .Net 8 unit tests #8236

Add project with .Net 8 unit tests #8236

costin-zaharia-sonarsource commented Oct 20, 2023 •

edited

Loading

costin-zaharia-sonarsource Oct 20, 2023

costin-zaharia-sonarsource Oct 20, 2023

martin-strecker-sonarsource left a comment

martin-strecker-sonarsource Oct 23, 2023

martin-strecker-sonarsource Oct 23, 2023

martin-strecker-sonarsource Oct 23, 2023

costin-zaharia-sonarsource commented Oct 25, 2023

sonarcloud bot commented Oct 25, 2023

sonarcloud bot commented Oct 25, 2023

martin-strecker-sonarsource commented Oct 26, 2023

martin-strecker-sonarsource left a comment

	<!-- `-windows` is required in order to be able to reference SonarAnalyzer.UnitTests -->
	<!-- `-windows` is required in order to be able to reference SonarAnalyzer.UnitTests to resolve e.g. WinForms references -->

Add project with .Net 8 unit tests #8236

Add project with .Net 8 unit tests #8236

Conversation

costin-zaharia-sonarsource commented Oct 20, 2023 • edited Loading

costin-zaharia-sonarsource Oct 20, 2023

Choose a reason for hiding this comment

costin-zaharia-sonarsource Oct 20, 2023

Choose a reason for hiding this comment

martin-strecker-sonarsource left a comment

Choose a reason for hiding this comment

martin-strecker-sonarsource Oct 23, 2023

Choose a reason for hiding this comment

martin-strecker-sonarsource Oct 23, 2023

Choose a reason for hiding this comment

martin-strecker-sonarsource Oct 23, 2023

Choose a reason for hiding this comment

costin-zaharia-sonarsource commented Oct 25, 2023

sonarcloud bot commented Oct 25, 2023

sonarcloud bot commented Oct 25, 2023

martin-strecker-sonarsource commented Oct 26, 2023

martin-strecker-sonarsource left a comment

Choose a reason for hiding this comment

costin-zaharia-sonarsource commented Oct 20, 2023 •

edited

Loading