Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project with .Net 8 unit tests #8236

Merged
merged 8 commits into from
Oct 26, 2023
Merged

Add project with .Net 8 unit tests #8236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dbb8a35
Add project with .Net 8 unit tests
costin-zaharia-sonarsource Oct 20, 2023
62802fa
Address comments
sebastien-marichal Oct 23, 2023
3018b25
Add azure-pipelines changes
sebastien-marichal Oct 24, 2023
de4b837
Fix errors in azure-pipeline.yml
sebastien-marichal Oct 24, 2023
997ea13
Azure-pipeline debug
sebastien-marichal Oct 24, 2023
1d0a6c7
Remove background jobs for UT execution
sebastien-marichal Oct 25, 2023
1ee5d29
Change back the namespace to Net8
costin-zaharia-sonarsource Oct 25, 2023
0c2d013
Update unit tests to use a parameter
costin-zaharia-sonarsource Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions analyzers/SonarAnalyzer.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "AnalysisConfig", "AnalysisC
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "SonarAnalyzer.SourceGenerators", "src\SonarAnalyzer.SourceGenerators\SonarAnalyzer.SourceGenerators.csproj", "{76D6EBB8-D2B0-41C1-8880-027EC78CB7FF}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "SonarAnalyzer.Net8.UnitTest", "tests\SonarAnalyzer.Net8.UnitTest\SonarAnalyzer.Net8.UnitTest.csproj", "{DB0A158B-D003-47ED-8209-E70277EB0693}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -96,6 +98,10 @@ Global
{76D6EBB8-D2B0-41C1-8880-027EC78CB7FF}.Debug|Any CPU.Build.0 = Debug|Any CPU
{76D6EBB8-D2B0-41C1-8880-027EC78CB7FF}.Release|Any CPU.ActiveCfg = Release|Any CPU
{76D6EBB8-D2B0-41C1-8880-027EC78CB7FF}.Release|Any CPU.Build.0 = Release|Any CPU
{DB0A158B-D003-47ED-8209-E70277EB0693}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{DB0A158B-D003-47ED-8209-E70277EB0693}.Debug|Any CPU.Build.0 = Debug|Any CPU
{DB0A158B-D003-47ED-8209-E70277EB0693}.Release|Any CPU.ActiveCfg = Release|Any CPU
{DB0A158B-D003-47ED-8209-E70277EB0693}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand All @@ -108,6 +114,7 @@ Global
{28067DB4-C098-4A15-9846-2978711733F3} = {314A0C27-4768-4F15-B7FA-DC3C33C08180}
{C086048C-D183-4B4D-9D3C-A6E191F19680} = {0C3E0519-DB5C-47C0-ABB3-9D1FB23DFBAF}
{E044950A-098B-4090-B4FB-8D6BD086828B} = {0C3E0519-DB5C-47C0-ABB3-9D1FB23DFBAF}
{DB0A158B-D003-47ED-8209-E70277EB0693} = {B7233F78-E142-4882-B084-7C83BE472109}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {4259CA71-C565-42DD-8D58-F59819A11065}
Expand Down
9 changes: 9 additions & 0 deletions analyzers/tests/SonarAnalyzer.Net8.UnitTest/ReadMe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Description

This project contains the analyzer unit tests that need the .Net 8 specific runtime.

Due to the following issue we cannot change the main test project to use .Net 8: https://github.com/dotnet/roslyn/issues/69578#issuecomment-1744931047
martin-strecker-sonarsource marked this conversation as resolved.
Show resolved Hide resolved

The current solution uses the main test project as a dependency, in order to have access to the `Verifier` and `VerifierBuilder`. A temporary decision that will allow us to add support on time for .net 8.

The final design is to extract these test utilities in their own project to be able to reuse them where necessary. See: https://github.com/SonarSource/sonar-dotnet/issues/8237
martin-strecker-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
14 changes: 14 additions & 0 deletions analyzers/tests/SonarAnalyzer.Net8.UnitTest/Rules/SelfAssignmentTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
using Microsoft.VisualStudio.TestTools.UnitTesting;
using SonarAnalyzer.UnitTest.TestFramework;

namespace SonarAnalyzer.Net8.UnitTest.Rules;
martin-strecker-sonarsource marked this conversation as resolved.
Show resolved Hide resolved

[TestClass]
public class SelfAssignmentTest
{
private readonly VerifierBuilder builderCS = new VerifierBuilder<SonarAnalyzer.Rules.CSharp.SelfAssignment>().WithConcurrentAnalysis(false);

[TestMethod]
public void SelfAssignment() =>
builderCS.AddPaths("SelfAssignment.cs").WithOptions(ParseOptionsHelper.FromCSharp12).Verify();
Comment on lines +11 to +13
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to demonstrate that we can add .Net 8 unit tests on this project.

}
28 changes: 28 additions & 0 deletions analyzers/tests/SonarAnalyzer.Net8.UnitTest/SonarAnalyzer.Net8.UnitTest.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<!-- `-windows` is required in order to be able to reference SonarAnalyzer.UnitTests to resolve e.g. WinForms references -->
<TargetFramework>net8.0-windows</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="altcover" Version="8.6.68" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
<PackageReference Include="MSTest.TestAdapter" Version="3.1.1" />
<PackageReference Include="MSTest.TestFramework" Version="3.1.1" />
</ItemGroup>

<ItemGroup>
<Compile Remove="TestCases\**\*" />
<None Include="TestCases\**\*">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\SonarAnalyzer.UnitTest\SonarAnalyzer.UnitTest.csproj" />
martin-strecker-sonarsource marked this conversation as resolved.
Show resolved Hide resolved
</ItemGroup>

</Project>
16 changes: 16 additions & 0 deletions analyzers/tests/SonarAnalyzer.Net8.UnitTest/TestCases/SelfAssignment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
namespace SonarAnalyzer.Net8.UnitTest.TestCases;

class WithInlineArrays
{
void Test(Buffer b)
{
b = b; // Noncompliant: local to local assignment
// Secondary@-1
}

[System.Runtime.CompilerServices.InlineArray(10)]
struct Buffer
{
int arrayItem;
}
}
Loading