SCANNPM-39 exit parent process w correct exit code (#153)

SonarSource · Jul 19, 2024 · 744dc70 · 744dc70
1 parent 9b2187a
commit 744dc70
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/src/scan.ts b/src/scan.ts
@@ -33,6 +33,7 @@ export async function scan(scanOptions: ScanOptions, cliArgs?: CliArgs) {
     await runScan(scanOptions, cliArgs);
   } catch (error) {
     log(LogLevel.ERROR, `An error occurred: ${error}`);
+    throw error;
   }
 }
 

diff --git a/test/unit/scan.test.ts b/test/unit/scan.test.ts
@@ -112,7 +112,9 @@ describe('scan', () => {
       jest.spyOn(scannerCli, 'runScannerCli');
       jest.spyOn(process, 'locateExecutableFromPath').mockResolvedValue(null);
 
-      await scan({ serverUrl: 'http://localhost:9000', localScannerCli: true });
+      await expect(
+        scan({ serverUrl: 'http://localhost:9000', localScannerCli: true }),
+      ).rejects.toThrow(Error);
 
       expect(scannerCli.downloadScannerCli).not.toHaveBeenCalled();
       expect(scannerCli.runScannerCli).not.toHaveBeenCalled();
@@ -176,12 +178,14 @@ describe('scan', () => {
       jest.spyOn(scannerEngine, 'runScannerEngine');
       jest.spyOn(process, 'locateExecutableFromPath').mockResolvedValue(null);
 
-      await scan({
-        serverUrl: 'http://localhost:9000',
-        options: {
-          [ScannerProperty.SonarScannerSkipJreProvisioning]: 'true',
-        },
-      });
+      await expect(
+        scan({
+          serverUrl: 'http://localhost:9000',
+          options: {
+            [ScannerProperty.SonarScannerSkipJreProvisioning]: 'true',
+          },
+        }),
+      ).rejects.toThrow(Error);
 
       expect(scannerEngine.runScannerEngine).not.toHaveBeenCalled();
       expect(scannerCli.runScannerCli).not.toHaveBeenCalled();