SCANNPM-39 exit parent process w correct exit code #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdiez
reviewed
Jul 15, 2024
vdiez
approved these changes
Jul 15, 2024
7PH
reviewed
Jul 15, 2024
7PH
requested changes
Jul 16, 2024
There was a problem hiding this comment.
I realize now that adding process.exit(..) either on top-level or the one when running the Scanner Engine will break the JS API, eg an user who calls
await scan({ .. })
scanWithCallback({..}, (error) => { .. })Will have his program shutting down immediately, but that's not what we want to do! - See runner.ts
lucas-paulger-sonarsource
force-pushed
the
fix/fail-w-exit-code
branch
from
1a9df8c to
2ed7725
Compare
7PH
reviewed
Jul 16, 2024
lucas-paulger-sonarsource
force-pushed
the
fix/fail-w-exit-code
branch
from
d60a005 to
c0ebaec
Compare
lucas-paulger-sonarsource
force-pushed
the
fix/fail-w-exit-code
branch
from
c0ebaec to
20af54c
Compare
|
|
Hello, thanks for fixing this issue. Could you please create a release and publish a new version to NPM? (asking, because 4.1.0 wasn't published on NPM) |
|
Could you please share your plans about when it will be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.