-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCANNPM-2 Detect Platform #110
SCANNPM-2 Detect Platform #110
Conversation
preset: 'ts-jest', | ||
testEnvironment: 'node', | ||
collectCoverageFrom: ['src/**/*.{js,ts}'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added support for ts, but I think this won't work with the js tests that exist. so need to cleanup and make sure we are left with no js tests 😅
e974a3e
to
ff7b7e7
Compare
log(LogLevel.DEBUG, 'Finding platform info'); | ||
const platformInfo = getPlatformInfo(); | ||
log(LogLevel.INFO, 'Platform: ', platformInfo); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to conditionally skip this with the presence of sonar.scanner.skipArchDetection
@7PH let me know if you have any process or suggestion on how we want to do this 🙇🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this PR you'll get the properties
object available right before these lines, so we'll be able to use the object to decide whether to detect or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀 Just 1 potential concern when looking at the platform sanitization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, 1 NP, feel free to ignore 👍
47c8e9f
to
020d58d
Compare
d8fc335
into
feature/MMF-3712
No description provided.