forked from bellingard/sonar-scanner-npm
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCANNPM-10 Handle logic to process scanner properties from various sources with priority #111
Merged
7PH
merged 1 commit into
feature/MMF-3712
from
feature/br/scannpm-10-handle-scanner-properties-logic
Apr 16, 2024
Merged
SCANNPM-10 Handle logic to process scanner properties from various sources with priority #111
7PH
merged 1 commit into
feature/MMF-3712
from
feature/br/scannpm-10-handle-scanner-properties-logic
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7PH
force-pushed
the
feature/br/scannpm-10-handle-scanner-properties-logic
branch
2 times, most recently
from
April 12, 2024 14:22
5bce82c
to
dfe3265
Compare
7PH
force-pushed
the
feature/br/scannpm-10-handle-scanner-properties-logic
branch
2 times, most recently
from
April 15, 2024 10:20
9bc62ef
to
af58590
Compare
test/unit/fixtures/fake_project_with_sonar_properties_file/sonar-project.properties
Show resolved
Hide resolved
7PH
force-pushed
the
feature/br/scannpm-10-handle-scanner-properties-logic
branch
2 times, most recently
from
April 15, 2024 11:01
0e7dee4
to
1b70138
Compare
7PH
force-pushed
the
feature/br/scannpm-10-handle-scanner-properties-logic
branch
from
April 15, 2024 11:04
1b70138
to
95ad4ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some outstanding comments/questions before approving
7PH
force-pushed
the
feature/br/scannpm-10-handle-scanner-properties-logic
branch
4 times, most recently
from
April 16, 2024 09:27
afbda26
to
b41a937
Compare
7PH
force-pushed
the
feature/br/scannpm-10-handle-scanner-properties-logic
branch
3 times, most recently
from
April 16, 2024 12:11
0c84704
to
0ba3291
Compare
lucas-paulger-sonarsource
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7PH
force-pushed
the
feature/br/scannpm-10-handle-scanner-properties-logic
branch
from
April 16, 2024 12:12
0ba3291
to
5137e94
Compare
…rces with priority
7PH
force-pushed
the
feature/br/scannpm-10-handle-scanner-properties-logic
branch
from
April 16, 2024 12:18
5137e94
to
4dffe8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
properties.ts
coverage