Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCANNPM-10 Handle logic to process scanner properties from various sources with priority #111

Merged

Conversation

7PH
Copy link
Member

@7PH 7PH commented Apr 12, 2024

properties.ts coverage
image
image

@7PH 7PH marked this pull request as draft April 12, 2024 14:01
@7PH 7PH force-pushed the feature/br/scannpm-10-handle-scanner-properties-logic branch 2 times, most recently from 5bce82c to dfe3265 Compare April 12, 2024 14:22
@7PH 7PH mentioned this pull request Apr 12, 2024
@7PH 7PH force-pushed the feature/br/scannpm-10-handle-scanner-properties-logic branch 2 times, most recently from 9bc62ef to af58590 Compare April 15, 2024 10:20
@7PH 7PH marked this pull request as ready for review April 15, 2024 10:21
@7PH 7PH force-pushed the feature/br/scannpm-10-handle-scanner-properties-logic branch 2 times, most recently from 0e7dee4 to 1b70138 Compare April 15, 2024 11:01
@7PH 7PH force-pushed the feature/br/scannpm-10-handle-scanner-properties-logic branch from 1b70138 to 95ad4ee Compare April 15, 2024 11:04
Copy link

@lucas-paulger-sonarsource lucas-paulger-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have some outstanding comments/questions before approving

src/properties.ts Show resolved Hide resolved
src/properties.ts Outdated Show resolved Hide resolved
src/properties.ts Outdated Show resolved Hide resolved
src/properties.ts Show resolved Hide resolved
src/properties.ts Outdated Show resolved Hide resolved
src/properties.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
test/unit/mocks/FakeProjectMock.ts Outdated Show resolved Hide resolved
test/unit/properties.test.ts Outdated Show resolved Hide resolved
test/unit/properties.test.ts Show resolved Hide resolved
@7PH 7PH force-pushed the feature/br/scannpm-10-handle-scanner-properties-logic branch 4 times, most recently from afbda26 to b41a937 Compare April 16, 2024 09:27
@7PH 7PH force-pushed the feature/br/scannpm-10-handle-scanner-properties-logic branch 3 times, most recently from 0c84704 to 0ba3291 Compare April 16, 2024 12:11
Copy link

@lucas-paulger-sonarsource lucas-paulger-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@7PH 7PH force-pushed the feature/br/scannpm-10-handle-scanner-properties-logic branch from 0ba3291 to 5137e94 Compare April 16, 2024 12:12
@7PH 7PH force-pushed the feature/br/scannpm-10-handle-scanner-properties-logic branch from 5137e94 to 4dffe8c Compare April 16, 2024 12:18
@7PH 7PH merged commit f44dbd0 into feature/MMF-3712 Apr 16, 2024
0 of 4 checks passed
@7PH 7PH deleted the feature/br/scannpm-10-handle-scanner-properties-logic branch April 16, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants