-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCCPPGHA-6 Support Running on Linux ARM64 #57
Conversation
Currently there are no github hosted linux arm64 runners, which makes testing difficult, but a setup with self hosted runners was made on here |
ea9104a
to
2df64fa
Compare
5860491
to
8faa7c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments.
But more importantly, it is worth mentioning that this PR also updates the sonar-scanner version somewhere, so we have improved traceability.
8c5c946
to
d293765
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with functional validation using self-hosted runners:
I see there is a ticket blocking this one on Jira about updating the SonarCloud C++ tutorials to the new syntax, let me know if you want a review there as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this pull request upgrades the sonar-scanner to v6, but the other PR does as well.
I think it is a good idea to separate the scanner bump in a different commit (as you did with the other PR), is it possible to split the work in 2 commits? (Could be in this PR or we can keep the other PR as well)
Co-authored-by: Michael Jabbour <117195239+michael-jabbour-sonarsource@users.noreply.github.com>
d293765
to
f72c98b
Compare
List of checkpoint to verify/do before merging a PR.
Dev checklist
Reviewer checklist
Steps to validate this PR
Fill-in how you performed the validation, and how the reviewer can replicate it:
SONAR_SCANNER_URL_UNIVERSAL
andSONAR_SCANNER_SHA_UNIVERSAL
variables, and the variations on the other variables when running on Linux ARM64