Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update embedded JS/TS analyzer to 10.0.0.20728 #3721

Closed
wants to merge 2 commits into from
Closed

Update embedded JS/TS analyzer to 10.0.0.20728 #3721

wants to merge 2 commits into from

Conversation

ugras-ergun-sonarsource
Copy link
Contributor

fixes #3543

ugras-ergun-sonarsource
ugras-ergun-sonarsource commented Feb 15, 2023
View reviewed changes
src/EmbeddedVsix.UnitTests/TypeScriptRuleDefinitions_SanityChecks.cs
@@ -95,6 +95,6 @@ private static void CheckRules(string language, IEnumerable<RuleDefinition> rule
ruleDefinition.RuleKey.EndsWith(":S2260");

private static bool HasDefaultParameters(RuleDefinition ruleDefinition) =>
ruleDefinition.DefaultParams.Length > 0;
ruleDefinition.DefaultParams?.Length > 0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the best way to solve the error in the test.

Copy link
Contributor

@duncanp-lseg duncanp-lseg Feb 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more context would be useful. If I understand correctly, you've changed the test so that it won't fail if a rule doesn't have default parameters.

Does our product code handle this case? Presumably before it was assuming that the default parameters might be empty but not null.

Is this actually a change of format by the JS/TS bubble, and if so was it intended?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ugras-ergun-sonarsource ugras-ergun-sonarsource marked this pull request as ready for review February 15, 2023 16:34
@rita-gorokhod rita-gorokhod deleted the ue/jsts10 branch February 21, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duncanp-lseg duncanp-lseg Awaiting requested review from duncanp-lseg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ugras-ergun-sonarsource @duncanp-lseg