Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embedded JS/TS analyzer to 10.0.0.20728 #3721

Closed
wants to merge 2 commits into from
Closed

Update embedded JS/TS analyzer to 10.0.0.20728 #3721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ab337c
Update embedded JS/TS analyzer to 10.0.0.20728
ugras-ergun-sonarsource Feb 15, 2023
74bc846
null check added
ugras-ergun-sonarsource Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EmbeddedSonarAnalyzer.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<!-- Note: Guide on how to update the analyzers is on the xtranet! -->
<EmbeddedSonarAnalyzerVersion>8.52.0.60960</EmbeddedSonarAnalyzerVersion>
<EmbeddedSonarCFamilyAnalyzerVersion>6.42.0.61084</EmbeddedSonarCFamilyAnalyzerVersion>
<EmbeddedSonarJSAnalyzerVersion>9.12.0.20319</EmbeddedSonarJSAnalyzerVersion>
<EmbeddedSonarJSAnalyzerVersion>10.0.0.20728</EmbeddedSonarJSAnalyzerVersion>
<EmbeddedSonarSecretsAnalyzerVersion>1.0.3</EmbeddedSonarSecretsAnalyzerVersion>
</PropertyGroup>

Expand Down
2 changes: 1 addition & 1 deletion src/EmbeddedVsix.UnitTests/TypeScriptRuleDefinitions_SanityChecks.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,6 @@ private static bool EslintKeyIsValid(RuleDefinition ruleDefinition) =>
ruleDefinition.RuleKey.EndsWith(":S2260");

private static bool HasDefaultParameters(RuleDefinition ruleDefinition) =>
ruleDefinition.DefaultParams.Length > 0;
ruleDefinition.DefaultParams?.Length > 0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the best way to solve the error in the test.

Copy link
Contributor

@duncanp-lseg duncanp-lseg Feb 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more context would be useful. If I understand correctly, you've changed the test so that it won't fail if a rule doesn't have default parameters.

Does our product code handle this case? Presumably before it was assuming that the default parameters might be empty but not null.

Is this actually a change of format by the JS/TS bubble, and if so was it intended?

}
}