Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sov-stf-runner should not depend on modules #991

Merged

Conversation

citizen-stig
Copy link
Member

@citizen-stig citizen-stig commented Oct 6, 2023

Description

sov-stf-runner suppose to be independent from module system.

This PR solves this by doing following things:

  • Replace re-exports from sov-modules-api to direct import from sov-rollup-interface
  • Moving concrete implementation of batch builder FiFoStrictBatchBuilder to sov-sequencer
  • RollupConfig now do not depend on concrete StorageConfig, but it is generic instead.
  • sov-modules-api was dependent on sov-sequencer only for to_jsonrpsee_error_object function. So it got moved to sov-modules-api, since sov-sequencer already depends on it. And for ledger_rpc it is copied, to avoid bringing whole sov-modules-api dependency.

Testing

Existing tests are passing

Docs

No updates in documentation

@citizen-stig citizen-stig self-assigned this Oct 6, 2023
@citizen-stig citizen-stig changed the title Nikolai/sov stf runner should not depend on modules sov-stf-runner should not depend on modules Oct 6, 2023
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #991 (757b1b8) into nightly (66c27de) will increase coverage by 0.7%.
Report is 4 commits behind head on nightly.
The diff coverage is 53.3%.

Files Coverage Δ
full-node/sov-sequencer/src/batch_builder.rs 98.0% <ø> (ø)
full-node/sov-sequencer/src/lib.rs 93.0% <ø> (ø)
full-node/sov-sequencer/src/utils.rs 50.9% <ø> (-6.0%) ⬇️
full-node/sov-stf-runner/src/config.rs 100.0% <100.0%> (ø)
full-node/sov-stf-runner/src/lib.rs 100.0% <ø> (ø)
full-node/sov-stf-runner/src/runner.rs 74.1% <ø> (ø)
full-node/sov-stf-runner/src/verifier.rs 0.0% <ø> (ø)
module-system/sov-modules-api/src/utils.rs 100.0% <100.0%> (ø)
full-node/sov-stf-runner/src/ledger_rpc.rs 83.7% <0.0%> (-8.8%) ⬇️

... and 11 files with indirect coverage changes

@citizen-stig citizen-stig marked this pull request as ready for review October 6, 2023 11:51
@citizen-stig citizen-stig added this pull request to the merge queue Oct 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 6, 2023
@citizen-stig citizen-stig added this pull request to the merge queue Oct 6, 2023
Merged via the queue into nightly with commit d85fa58 Oct 6, 2023
12 checks passed
@citizen-stig citizen-stig deleted the nikolai/sov_stf_runner_should_not_depend_on_modules branch October 6, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants