-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sov-stf-runner
should not depend on modules
#991
Merged
citizen-stig
merged 7 commits into
nightly
from
nikolai/sov_stf_runner_should_not_depend_on_modules
Oct 6, 2023
Merged
sov-stf-runner
should not depend on modules
#991
citizen-stig
merged 7 commits into
nightly
from
nikolai/sov_stf_runner_should_not_depend_on_modules
Oct 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citizen-stig
changed the title
Nikolai/sov stf runner should not depend on modules
Oct 6, 2023
sov-stf-runner
should not depend on modules
Codecov Report
|
bkolad
reviewed
Oct 6, 2023
bkolad
approved these changes
Oct 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 6, 2023
citizen-stig
deleted the
nikolai/sov_stf_runner_should_not_depend_on_modules
branch
October 6, 2023 16:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sov-stf-runner
suppose to be independent from module system.This PR solves this by doing following things:
sov-modules-api
to direct import fromsov-rollup-interface
FiFoStrictBatchBuilder
tosov-sequencer
RollupConfig
now do not depend on concreteStorageConfig
, but it is generic instead.sov-modules-api
was dependent onsov-sequencer
only forto_jsonrpsee_error_object
function. So it got moved tosov-modules-api
, sincesov-sequencer
already depends on it. And for ledger_rpc it is copied, to avoid bringing wholesov-modules-api
dependency.Testing
Existing tests are passing
Docs
No updates in documentation