-
Notifications
You must be signed in to change notification settings - Fork 8
Feat/alpha 129 #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/alpha 129 #43
Conversation
Signed-off-by: Jan Schoone <schoone@osb-alliance.com>
Signed-off-by: Jan Schoone <schoone@osb-alliance.com>
Signed-off-by: Jan Schoone <schoone@osb-alliance.com>
|
Hi @chess-knight, could you test this release on gx-scs (or an Openstack cloud of your choice 😄) using CSO and CSPO? This is alread available as pre-release. Hi @janiskemper, could you have a look if the Cluster Stack structure is as it should be? I still use the << >> notation here, when I understand the issue you sent me (SovereignCloudStack/csctl#102) correct, this can be avoided in the future? For both of you, of course, you are welcome to pass the review request on to a teammate. :) |
chess-knight
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jschoone, I tested the pre-release and it works for me.
The helper chart also works, but what confused me was the ability to create a namespace. The helper chart creates a namespace itself based on project_name or application_credential_id from clouds.yaml and then, all resources must be created in this concrete namespace - what is not a case e.g. of quickstart guide, where the namespace: cluster is used.
|
I can also confirm that this release works (i mean what is in the release, not this PR :) @chess-knight yes, the helper chart is not where it should be yet. The idea with the project-namespace relation is that all the resources (namespace, secrets, CSO, CSPO resources) are needed per namespace and tenant (which brings me to a 1:1 relation of tenant and namespace). If you have a non-application-credential you can extract the tenant/namespace nicely from project_name. I created a separate issue for that (#46) if you have an idea how to deal with it, your proposal is more than welcome :) |
janiskemper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes you should use that notation until further notice @jschoone
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: