Skip to content

Conversation

@jschoone
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Jan Schoone added 3 commits March 18, 2024 18:29
Signed-off-by: Jan Schoone <schoone@osb-alliance.com>
Signed-off-by: Jan Schoone <schoone@osb-alliance.com>
Signed-off-by: Jan Schoone <schoone@osb-alliance.com>
@jschoone jschoone added the Container Issues or pull requests relevant for Team 2: Container Infra and Tooling label Mar 18, 2024
@jschoone jschoone self-assigned this Mar 18, 2024
@jschoone jschoone linked an issue Mar 18, 2024 that may be closed by this pull request
@jschoone
Copy link
Contributor Author

Hi @chess-knight, could you test this release on gx-scs (or an Openstack cloud of your choice 😄) using CSO and CSPO? This is alread available as pre-release.
For the secret for the workload cluster I still use the Helm chart from Malte this way: helm template https://github.com/SovereignCloudStack/cluster-stacks/releases/download/openstack-alpha-1-28-v3/csp-helper-chart.tgz -f path/to/clouds.yaml | kubectl apply -f -
If that works, I suggest to have this in the Quickstart docs in the CSPO including ClusterStack, OpenStackClusterStackReleaseTemplate and Cluster examples, because it's currently a bit confusing when reading this on the docs page instead of the CSPO repo itself.

Hi @janiskemper, could you have a look if the Cluster Stack structure is as it should be? I still use the << >> notation here, when I understand the issue you sent me (SovereignCloudStack/csctl#102) correct, this can be avoided in the future?

For both of you, of course, you are welcome to pass the review request on to a teammate. :)

Copy link
Member

@chess-knight chess-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jschoone, I tested the pre-release and it works for me.

The helper chart also works, but what confused me was the ability to create a namespace. The helper chart creates a namespace itself based on project_name or application_credential_id from clouds.yaml and then, all resources must be created in this concrete namespace - what is not a case e.g. of quickstart guide, where the namespace: cluster is used.

@chess-knight
Copy link
Member

Hi @jschoone, I tested the pre-release and it works for me.

I also find that pre-release differs from this PR - securityGroups missing in the OpenStack templates. So I guess you also noticed it, so you removed it from pre-release. Please, check #45

@mxmxchere
Copy link

mxmxchere commented Mar 20, 2024

I can also confirm that this release works (i mean what is in the release, not this PR :)

@chess-knight yes, the helper chart is not where it should be yet. The idea with the project-namespace relation is that all the resources (namespace, secrets, CSO, CSPO resources) are needed per namespace and tenant (which brings me to a 1:1 relation of tenant and namespace). If you have a non-application-credential you can extract the tenant/namespace nicely from project_name. I created a separate issue for that (#46) if you have an idea how to deal with it, your proposal is more than welcome :)

Copy link
Member

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you should use that notation until further notice @jschoone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Container Issues or pull requests relevant for Team 2: Container Infra and Tooling

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Create Openstack Cluster Stacks for Kubernetes v1.29

5 participants