✨ Overwrite helm chart version. No need for templating. #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jschoone you can check this out! |
kranurag7
force-pushed
the
syself/csctl-chart-templating
branch
from
8cc300a to
0a80b2c
Compare
3 tasks
Contributor
|
Hi @kranurag7, What I tried: When I change the value back to |
Member
❯ ./bin/csctl create tests/cluster-stacks/docker/ferrol -m hash -o .test-releases
Creating output in .test-releases/docker-ferrol-1-27-v0-sha-a2b3cbb
.tmp/cluster-addon/Chart.yaml updating version from v0 to v0-sha.a2b3cbb
.tmp/cluster-class/Chart.yaml updating version from v0 to v0-sha.a2b3cbb
No provider specifig configuration in csctl.yaml. No need to call a plugin for provider "docker"
Created .test-releases/docker-ferrol-1-27-v0-sha-a2b3cbb
☸️ kind-cso 📁 csctl on syself/csctl-chart-templating [!?] via v1.21.6
❯ ls .test-releases/docker-ferrol-1-27-v0-sha-a2b3cbb
cluster-addon-values.yaml docker-ferrol-1-27-cluster-addon-v0-sha.a2b3cbb.tgz docker-ferrol-1-27-cluster-class-v0-sha.a2b3cbb.tgz hashes.json metadata.yamlthis looks good I guess |
jschoone
approved these changes
May 8, 2024
Contributor
jschoone
left a comment
jschoone
left a comment
There was a problem hiding this comment.
Thanks @aniruddha2000, can confirm it works now.
this commit adds a feature in csctl where one doesn't require templating and Chart.yaml and csctl will override the version field in Chart.yaml Signed-off-by: Anurag <anurag.kumar@syself.com>
aniruddha2000
force-pushed
the
syself/csctl-chart-templating
branch
from
a2b3cbb to
fe2655a
Compare
Member
|
Squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit adds a feature in csctl where one doesn't require templating and Chart.yaml and csctl will override the version field in Chart.yaml
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: