Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mappings support #47

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Earthcomputer
Copy link

This PR is currently unfinished, and exists so that zml doesn't have to type a URL into the address bar.

@zml2008
Copy link
Member

zml2008 commented Jan 17, 2022

tossing some notes here on how I think we'll get to a releasable state given FART can't be on the buildscript classpath as-is:

  • Add ServiceLoader discovery for transformers to FART
  • run remapping jobs in classloader-isolation workers
  • ship a relocated version of SrgUtils with VanillaGradle in-jar, used to build mappings files
  • split out any custom transformers we use as separate artifacts that are then placed in the fartTransformers configuration of the target project

that's not ideal since things get weird with multi-project builds, but it does make things work

also, having an isolated remapper classpath allows us to fully capture the code inputs and regenerate artifacts if any of those inputs change, maybe?

@oliviathevampire
Copy link

How functional is this?

@Tslat

This comment was marked as spam.

@AdamCalculator

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants