Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Add long timeout arg to unit test launch configuration #1189

Merged
merged 1 commit into from
May 23, 2024
Merged

🔧 Add long timeout arg to unit test launch configuration #1189

merged 1 commit into from
May 23, 2024

Conversation

TheAfroOfDoom
Copy link
Contributor

@TheAfroOfDoom TheAfroOfDoom commented May 21, 2024 •
edited
Loading

  • when you're debugging these, it's not unlikely you'd be in a test longer than 30s (the default timeout)
  • new default is 999999s (11.5 days)

@TheAfroOfDoom
🔧 Add long timeout arg to unit test launch configuration
e186129 
- when you're debugging these, it's not unlikely you'd be in a test longer than 30s (the default timeout)
- new default is 999999s (11.5 days)
SPGoding
SPGoding approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@SPGoding SPGoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if we stare at a breakpoint continuously for 11.5 days?

@TheAfroOfDoom
Copy link
Contributor Author

what happens if we stare at a breakpoint continuously for 11.5 days?

GKfjTrfW8AE5HgN

TheAfroOfDoom added a commit to TheAfroOfDoom/Spyglass that referenced this pull request May 21, 2024
@TheAfroOfDoom
⏪ Revert launch.json changes
0cf6c17 
- split to SpyglassMC#1189
@TheAfroOfDoom TheAfroOfDoom mentioned this pull request May 21, 2024
Merged
@misode misode merged commit 9a303cc into SpyglassMC:main May 23, 2024
3 checks passed
@TheAfroOfDoom TheAfroOfDoom deleted the increase-timeout-debug-unit-tests branch May 23, 2024 02:34
TheAfroOfDoom added a commit to TheAfroOfDoom/Spyglass that referenced this pull request May 24, 2024
@TheAfroOfDoom
🔧 Add long timeout arg to unit test launch configuration (SpyglassMC#…
d4e181a 
…1189)
TheAfroOfDoom added a commit to TheAfroOfDoom/Spyglass that referenced this pull request May 24, 2024
@TheAfroOfDoom
Squashed commit of the following:
d3705e0 
commit a8431ea
Author: SPGoding <i@spgoding.com>
Date:   Thu May 23 16:54:49 2024 -0500

    🐛 Fix computing relative URIs (SpyglassMC#1177)

commit 0c5e505
Author: Afro <tehafroofdoom@gmail.com>
Date:   Thu May 23 17:53:36 2024 -0400

    🔧 Add `import/no-duplicates` lint rule (SpyglassMC#1181)

commit 50c2185
Author: SPGoding <i@spgoding.com>
Date:   Wed May 22 21:26:34 2024 -0500

    🔥 Remove CommandTreeRegistry (SpyglassMC#1190)

commit 6439d5f
Author: NeunEinser <daniel30797@gmail.com>
Date:   Thu May 23 04:24:54 2024 +0200

    🚧 Remove attributed type in favor of attributes array on all types (SpyglassMC#1182)

commit d99eeb6
Author: SPGoding <i@spgoding.com>
Date:   Wed May 22 21:22:37 2024 -0500

    ⬆️ Upgrade dprint (SpyglassMC#1191)

commit 9a303cc
Author: Afro <tehafroofdoom@gmail.com>
Date:   Wed May 22 22:21:45 2024 -0400

    🔧 Add long timeout arg to unit test launch configuration (SpyglassMC#1189)

commit 2b74e1f
Author: Nico314159 <nicolino.will@gmail.com>
Date:   Wed May 22 13:04:25 2024 -0700

    Implement 1.20.5+ item slots (SpyglassMC#1179)

commit d6c395f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue May 21 02:58:56 2024 -0500

    ⬆️ Bump rexml from 3.2.5 to 3.2.8 in /docs (SpyglassMC#1153)

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit a1f81c3
Author: NeunEinser <daniel30797@gmail.com>
Date:   Mon May 20 22:15:26 2024 +0200

    🐛 Fix message reporting breaking on empty string (SpyglassMC#1155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPGoding SPGoding SPGoding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheAfroOfDoom @SPGoding @misode