🔥 Remove CommandTreeRegistry #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unnecessary abstraction that obscures things.
TheAfroOfDoom
approved these changes
May 21, 2024
__snapshots__/packages/language-server/test-out/util/toLS.spec.js
Outdated
Show resolved
Hide resolved
misode
approved these changes
May 23, 2024
TheAfroOfDoom
pushed a commit
to TheAfroOfDoom/Spyglass
that referenced
this pull request
May 24, 2024
TheAfroOfDoom
added a commit
to TheAfroOfDoom/Spyglass
that referenced
this pull request
May 24, 2024
commit a8431ea Author: SPGoding <i@spgoding.com> Date: Thu May 23 16:54:49 2024 -0500 🐛 Fix computing relative URIs (SpyglassMC#1177) commit 0c5e505 Author: Afro <tehafroofdoom@gmail.com> Date: Thu May 23 17:53:36 2024 -0400 🔧 Add `import/no-duplicates` lint rule (SpyglassMC#1181) commit 50c2185 Author: SPGoding <i@spgoding.com> Date: Wed May 22 21:26:34 2024 -0500 🔥 Remove CommandTreeRegistry (SpyglassMC#1190) commit 6439d5f Author: NeunEinser <daniel30797@gmail.com> Date: Thu May 23 04:24:54 2024 +0200 🚧 Remove attributed type in favor of attributes array on all types (SpyglassMC#1182) commit d99eeb6 Author: SPGoding <i@spgoding.com> Date: Wed May 22 21:22:37 2024 -0500 ⬆️ Upgrade dprint (SpyglassMC#1191) commit 9a303cc Author: Afro <tehafroofdoom@gmail.com> Date: Wed May 22 22:21:45 2024 -0400 🔧 Add long timeout arg to unit test launch configuration (SpyglassMC#1189) commit 2b74e1f Author: Nico314159 <nicolino.will@gmail.com> Date: Wed May 22 13:04:25 2024 -0700 Implement 1.20.5+ item slots (SpyglassMC#1179) commit d6c395f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue May 21 02:58:56 2024 -0500 ⬆️ Bump rexml from 3.2.5 to 3.2.8 in /docs (SpyglassMC#1153) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a1f81c3 Author: NeunEinser <daniel30797@gmail.com> Date: Mon May 20 22:15:26 2024 +0200 🐛 Fix message reporting breaking on empty string (SpyglassMC#1155)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unnecessary abstraction that obscures things. If we ever end up having multiple versions of the tree available at the same time, whatever package's responsible for that should manage all the trees internally.