ref: Remove redundant, duplicate styles and remove storypage widget as its not in use. #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s its not in use.
…as it is no longer in use
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused storypage widget and the story-line-expanded template styles, while refactoring expanded-tiles styles in the nightfall widget to improve code organization. The changes eliminate redundant and duplicate styling code that was not in active use.
- Completely removes the
storypagewidget including all TypeScript, SCSS, and Handlebars template files - Deletes the unused
story-line-expandedtemplate styles (_index.scssand_dimens.scss) - Extracts
expanded-tilesstyles fromnightfall/_components.scssinto a dedicated_expanded-tiles.scssfile - Removes
expanded-tilesselector references from multiple widget style files (shortvideo,storyline,starter-project) that were causing duplicate style application
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| widgets/storypage/* | Complete removal of the storypage widget (TypeScript, SCSS, Handlebars files) |
| widgets/styles/templates/story-line-expanded/* | Deletion of unused story-line-expanded template styles |
| widgets/nightfall/_expanded-tiles.scss | New file extracting expanded-tiles styles from _components.scss |
| widgets/nightfall/_components.scss | Refactored to import expanded-tiles from separate file |
| widgets/shortvideo/_icon-sections-override.scss | Removed duplicate expanded-tiles selector block |
| widgets/shortvideo/_styles.scss | Removed expanded-tiles from combined selector |
| widgets/shortvideo/_tile-content-override.scss | Removed duplicate expanded-tiles selector block |
| widgets/starter-project/_styles.scss | Removed expanded-tiles from combined selector |
| widgets/storyline/_icon-sections-override.scss | Removed duplicate expanded-tiles selector block |
| widgets/storyline/_styles.scss | Removed expanded-tiles from combined selector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up styles, and remove direct uploader widget not in use (and likely not shipped for a while. can be restored from this PR if needed).
Motivation and Context
Related Jira ticket
Testing
Documentation
Checklist
Screenshots