Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial restructuring of the onboarding flow #8

Merged
merged 13 commits into from
Jun 17, 2023
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Jun 11, 2023

Initial restructuring of the onboarding flow

♻️ Current situation & Problem

As of right now, the app provides the onboarding flow as implemented in the template app.

💡 Proposed solution

This PR introduces the onboarding flow for NAMS by removing not needed features of the template and updating text accordingly.

⚙️ Release Notes

  • First version of the app's onboarding flow

➕ Additional Information

Related PRs

--

Testing

TBA: test have to be adapted

Reviewer Nudging

Entry point to the review should be the OnboardingFlow view, where everything starts, even for the user.

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@Supereg Supereg mentioned this pull request Jun 11, 2023
1 task
@Supereg Supereg marked this pull request as ready for review June 12, 2023 15:10
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #8 (0264ddf) into main (7bcad83) will decrease coverage by 1.65%.
The diff coverage is 95.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
- Coverage   92.98%   91.32%   -1.65%     
==========================================
  Files          26       24       -2     
  Lines         655      576      -79     
==========================================
- Hits          609      526      -83     
- Misses         46       50       +4     
Impacted Files Coverage Δ
NAMS/Helper/CodableArray+RawRepresentable.swift 42.86% <ø> (ø)
NAMS/NAMSAppDelegate.swift 96.78% <ø> (-0.95%) ⬇️
NAMS/Onboarding/AccountSetup/IconView.swift 100.00% <ø> (ø)
NAMS/Onboarding/AccountSetup/NAMSLogin.swift 0.00% <ø> (ø)
NAMS/Onboarding/AccountSetup/NAMSSignUp.swift 100.00% <ø> (ø)
NAMS/Schedule/NAMSTaskContext.swift 50.00% <ø> (ø)
NAMS/Onboarding/AccountSetup/AccountSetup.swift 92.64% <62.50%> (-2.87%) ⬇️
NAMS/Home.swift 100.00% <100.00%> (ø)
NAMS/NAMSApp.swift 100.00% <100.00%> (ø)
NAMS/NAMSTestingSetup.swift 100.00% <100.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bcad83...0264ddf. Read the comment docs.

@Supereg Supereg requested a review from PSchmiedmayer June 13, 2023 18:10
@PSchmiedmayer
Copy link
Member

Thank you for the initial changes, this already looks gerat @Supereg! 🚀

@Supereg Supereg merged commit 40244c1 into main Jun 17, 2023
@Supereg Supereg deleted the feature/initial-changes branch June 17, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants