[BugFix]streamvbyte decode should use RawVectorPad16 to correctly use avx #13062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fzhedu <fzhedu@gmail.com>
Signed-off-by: fzhedu <fzhedu@gmail.com>
kangkaisen
previously approved these changes
Nov 7, 2022
murphyatwork
previously approved these changes
Nov 8, 2022
Signed-off-by: fzhedu <fzhedu@gmail.com>
auto-merge was automatically disabled
November 8, 2022 03:30
Head branch was pushed to by a user without write access
Signed-off-by: fzhedu <fzhedu@gmail.com>
kangkaisen
approved these changes
Nov 8, 2022
murphyatwork
approved these changes
Nov 8, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
run starrocks_admit_test |
1 similar comment
|
run starrocks_admit_test |
fzhedu
added a commit
to fzhedu/starrocks
that referenced
this pull request
Nov 15, 2022
…ctly use avx (StarRocks#13062)" This reverts commit 2959bdd.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: fzhedu fzhedu@gmail.com
What type of PR is this：
Which issues of this PR fixes ：
Fixes #https://github.com/StarRocks/StarRocksBenchmark/issues/273
Problem Summary(Required) ：
fast-pack/streamvbyte#44 fix a error that streamvbyte's decode may read up to 16 extra bytes from the input (beyond the actual compressed data). Thus the users of this library, for safety, should ensure that there is allocated data 16 bytes beyond the compressed data.
SR can use
RawVectorPad16to allocate vector with extra 16 bytes. So this PR introducesmake_room_pad16to make room for decoding integers that encoded by streamvbyte.by the way, refactor some codes.
Checklist: