Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and verifies issue 42 #44

Merged
merged 2 commits into from
Aug 6, 2022
Merged

Fixes and verifies issue 42 #44

merged 2 commits into from
Aug 6, 2022

Conversation

lemire
Copy link
Member

@lemire lemire commented Aug 6, 2022

We decoding, our functions may read up to 16 extra bytes from the input (beyond the actual compressed data). Thus the users of this library, for safety, should ensure that there is allocated data 16 bytes beyond the compressed data.

@fzhedu
Copy link

fzhedu commented Nov 14, 2022

@lemire I think we should pad 32 bytes for AVX as the vector lane of AVX is up to 256bits.
streamvbyte

@lemire
Copy link
Member Author

lemire commented Nov 14, 2022

@fzhedu We only read into 16-byte registers (so not 32 bytes). However, there may yet still be a bug. Can you share the input that was used to produce this case so we can examine it and produce a fix?

@lemire
Copy link
Member Author

lemire commented Nov 14, 2022

It would be most useful if you can raise this as a new issue.

@lemire
Copy link
Member Author

lemire commented Nov 14, 2022

I do refer you to documentation, this bit is important...

During decoding, the library may read up to STREAMVBYTE_PADDING extra bytes
from the input buffer (these bytes are read but never used).

This requirement could be removed.

@fzhedu
Copy link

fzhedu commented Nov 15, 2022

@fzhedu We only read into 16-byte registers (so not 32 bytes). However, there may yet still be a bug. Can you share the input that was used to produce this case so we can examine it and produce a fix?

ok, I will recheck and test again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

About a warning from valgrind when running through valgrind
2 participants