Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image selection guide #491

Merged
merged 5 commits into from
Apr 20, 2021
Merged

Image selection guide #491

merged 5 commits into from
Apr 20, 2021

Conversation

JessicaBarh
Copy link
Contributor

@JessicaBarh JessicaBarh commented Apr 20, 2021

provide a description of the images and their uses to help users select the best one for their needs.
1 of 2 PRs for #358
2nd PR adds the url link on the "Create Notebook Server" page in Kubeflow that directs user to this docs: StatCan/jupyter-apis#60

Copy link
Contributor

@ca-scribner ca-scribner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Only request I have is could you add a link to this somewhere in the wiki too? Could also be done as a separate PR. Probably just needs a quick link in the RStudio/Jupyter pages?

@JessicaBarh
Copy link
Contributor Author

lgtm! Only request I have is could you add a link to this somewhere in the wiki too? Could also be done as a separate PR. Probably just needs a quick link in the RStudio/Jupyter pages?

Sounds good. I can add it with the translation of the rest of the wiki I'm doing.

@JessicaBarh JessicaBarh merged commit 6fbaf4f into master Apr 20, 2021
@Souheil-Yazji Souheil-Yazji deleted the image-selection-guide branch April 4, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants