Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Jupyter apis to v1.6.0 #132

Merged
merged 64 commits into from
Nov 3, 2022
Merged

Upgrade Jupyter apis to v1.6.0 #132

merged 64 commits into from
Nov 3, 2022

Conversation

mathis-marcotte
Copy link
Contributor

@mathis-marcotte mathis-marcotte commented Sep 13, 2022 •
edited
Loading

This branch was built on top of "feat-upgrade-1.4"

@mathis-marcotte mathis-marcotte linked an issue Sep 13, 2022 that may be closed by this pull request
"Rebase" for 1.6 Crud-web-apps StatCan/aaw#1342
Closed
wg102
wg102 reviewed Sep 15, 2022
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated
@@ -3,6 +3,7 @@ on:
push:
branches:
- main
- feat-upgrade-1.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not needed please remove

Jose-Matsuda
Jose-Matsuda approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@Jose-Matsuda Jose-Matsuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will test and review on dev

@chuckbelisle chuckbelisle marked this pull request as draft September 20, 2022 19:18
@mathis-marcotte mathis-marcotte changed the title Upgrade frontend to v1.6.0 Upgrade Jupyter apis to v1.6.0 Sep 21, 2022
@Jose-Matsuda Jose-Matsuda mentioned this pull request Sep 21, 2022
Closed
Mathis Marcotte and others added 9 commits September 26, 2022 15:17
added back hint text
3a8e032
added back the icons in the form sections
8c9d0df
@mathis-marcotte
Merge pull request #148 from StatCan/fix-136-add-hint-text
52034bc 
Fix 136 add hint text
@mathis-marcotte
Fix 139 add volume table (#145)
f5d2d52 
* added back the volume table

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
@mathis-marcotte
Fix 140 add kubecost table (#149)
ec4741c 
* added back the kubecost table


Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
@mathis-marcotte
1.6 update - add sass (#147)
bf8cb52 
* added sas image

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
@mathis-marcotte
image pull policy fix (#151)
bb9529a 
Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
@mathis-marcotte
added back system language input (#150)
e522a64 
Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
@Jose-Matsuda
Validation fix (#144)
f72afcd 
* This adds back our custom changes introduced in #19, #51, #61. All changes have been noted with some comments to make this easier when we do it again next time.

* PLEASE NOTE. There are NO translations and there is test text. 

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
Collinbrown95 and others added 16 commits October 12, 2022 15:18
@Collinbrown95
Merge pull request #163 from StatCan/missing-storage-classes-endpoint
9c2cffd 
added missing api endpoint for getting storage classes
@Collinbrown95
Merge pull request #155 from StatCan/downward-api
66347d8 
add: emptydir for protb nb
@Collinbrown95
refactor(Dockerfile): bind API to new port
099bdc3
@Collinbrown95
Merge pull request #165 from StatCan/refactor/Dockerfile
437dd25 
refactor(Dockerfile): bind API to new port
@Collinbrown95
refactor(Dockerfile): change copy paths
1931282
@Collinbrown95
fix(environment): path to logo svgs
2388e8f
@Collinbrown95
fix(frontend): icon paths
a096bf3
@Collinbrown95
fix(frontend): svg paths
6d850d6
@mathis-marcotte
Update 1.6 translation files (#166)
4f005f1 
* updated messages files

* added custom paginator for translation

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
@Jose-Matsuda
1.6 fix volumes (#164)
37df279 
* update backend to handle new frontend structure

* remove unwanted features
@Jose-Matsuda
fix failing build? (#169)
1e5580f 
* fix failing builds, comment went one tag too deep
@Jose-Matsuda
remove unused commit
c695a0a
@bryanpaget
fix(volume name): update formCtrl.get() (#174)
223f6ab 
to formCtrl.get().value.
@bryanpaget
set(sizeNum): default to 16
cb55521
@bryanpaget
Merge pull request #175 from StatCan/fix-sizeNum-default-value
f839911 
set(sizeNum): default to 16
added missing json names
b4898ba
Mathis Marcotte and others added 7 commits October 28, 2022 14:06
reapplied changes
61a1d90
removed form elements for clarity
dc103a4
updated message files
21cdd47
@mathis-marcotte
added Pro b icon (#179)
4ae94ed 
* added pro b icon to notebook and volume table

Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
@mathis-marcotte
added current language context to system language input (#180)
f4091ed 
Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
updated message file
977f1e4
@mathis-marcotte
updated translations (#183)
069937d 
Co-authored-by: Mathis Marcotte <mathis.marcotte@statcan.gc.ca>
@Jose-Matsuda Jose-Matsuda marked this pull request as ready for review November 3, 2022 12:57
@Jose-Matsuda Jose-Matsuda merged commit 76e7415 into main Nov 3, 2022
@mathis-marcotte mathis-marcotte deleted the upgrade-frontend-1.6 branch November 22, 2022 17:51
@Jose-Matsuda Jose-Matsuda mentioned this pull request Apr 11, 2023
Closed
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wg102 wg102 wg102 left review comments

@Jose-Matsuda Jose-Matsuda Jose-Matsuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Rebase" for 1.6 Crud-web-apps
6 participants
@mathis-marcotte @wg102 @Jose-Matsuda @rohank07 @Collinbrown95 @bryanpaget