Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ControllerTools to v1.2.0 #632

Closed

Conversation

jfernandez
Copy link
Contributor

ControllerTools

Update ControllerTools to v1.2.0 and change the submodule to point to the new repository. The alphamercury repository is no longer maintained. You can verify this by going to the old url [1] and verifying that it redirects to the new url [2].

This new version pulls in the latest dependencies and makes the plugin use the global DFL to address an error [3] in the UI after the Steam Deck client update.

[1] https://github.com/alphamercury/ControllerTools
[2] https://github.com/jfernandez/ControllerTools
[3] jfernandez/ControllerTools#43

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • Yes: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes: I am using a custom binary that has all of it's dependencies statically linked.

Testing

Several users tested this new build in this Issue and verified it works: jfernandez/ControllerTools#43

  • Tested on SteamOS Stable/Beta Update Channel.
  • Tested on SteamOS Preview Update Channel.

Update ControllerTools to v1.2.0 and change the submodule to point to
the new repository. The alphamercury repository is no longer maintained.
You can verify this by going to the old url [1] and verifying that it
redirects to the new url [2].

This new version pulls in the latest dependencies and makes the plugin
use the global DFL to address an error [3] in the UI after the Steam Deck
client update.

[1] https://github.com/alphamercury/ControllerTools
[2] https://github.com/jfernandez/ControllerTools
[3] jfernandez/ControllerTools#43

Signed-off-by: Jose Fernandez <josef@netflix.com>
@jfernandez jfernandez requested a review from a team as a code owner May 27, 2024 14:42
Copy link
Member

@PartyWumpus PartyWumpus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for clarifying why the URL changed.

@PartyWumpus
Copy link
Member

PartyWumpus commented May 28, 2024

Build failed. The pnpm lockfile's lockfileVersion: '9.0' is too high, has to be at most '6.0'. I think it's because our runner is out of date?

@jfernandez
Copy link
Contributor Author

@PartyWumpus Anything I can do to help unblock this?

@PartyWumpus
Copy link
Member

@PartyWumpus Anything I can do to help unblock this?

I already said, the build failed because your lockfile version is too high. You need to use an older version of pnpm.

@jfernandez
Copy link
Contributor Author

Submitted a PR for 1.2.1 which uses pnpm 6 #636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants