Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property #43

Closed
dm82m opened this issue Mar 10, 2024 · 18 comments · Fixed by #49
Closed

Cannot read property #43

dm82m opened this issue Mar 10, 2024 · 18 comments · Fixed by #49
Assignees
Labels
bug Something isn't working

Comments

@dm82m
Copy link

dm82m commented Mar 10, 2024

With current steam beta client and pre release of decky it raises an TypeError Cannot read properties.

I guess it has something todo with: mcarlucci/decky-storage-cleaner#10

@TiZ-HugLife
Copy link

DFL needs to be bumped. See this specific comment of SteamDeckHomebrew/decky-loader#597. Thanks for your time.

@TiZ-HugLife
Copy link

It's not happening "again", it's just still happening. All the breaking changes from beta got shoved out into stable, so now everything with Decky is everyone's problem.

@jfernandez
Copy link
Owner

I'll look into updating DFL

@jfernandez
Copy link
Owner

controller-tools-1.2.0.zip

Could one of you manually install this release candidate to see if it fixes the problem?

@jfernandez jfernandez self-assigned this May 8, 2024
@jfernandez jfernandez added the bug Something isn't working label May 8, 2024
@costinvader
Copy link

This is what it says with that zip file installed
20240508_194317

@vbali
Copy link

vbali commented May 9, 2024

This is what it says with that zip file installed !

I'm experiencing the same issue with that zip file installed. Have you been able to find a solution or workaround?

@costinvader
Copy link

I'm not a developer, I just tested it, sorry bro

@jfernandez
Copy link
Owner

I'm going to ask in their discord why you are still getting that error.

@f3bandit
Copy link

controller-tools-1.2.0.zip

Could one of you manually install this release candidate to see if it fixes the problem?

not fixed

@Nachtfrische
Copy link

Nachtfrische commented May 20, 2024

The error I'm getting with version 1.2.0 is:

TypeError: plugin_export is not a function
       at PluginLoader.importReactPlugin (http://localhost:1337/frontend/chunk-ecb27f3b.js:6995:30)
       at async PluginLoader.importPlugin (http://localhost:1337/frontend/chunk-ecb27f3b.js:6969:17)

I quickly looked at your DFL update and it looked fine to me. Any idea on what else might cause this?

@jfernandez
Copy link
Owner

I’m out of ideas. I’ve also asked in the Decky discord and they also believe the update looks good. I could use some help debugging this further if anyone wants to help out.

@costinvader
Copy link

If this helps, the notification when the battery drops under 15% is still working, only the interface to see what's the actual battery level of the controller is not working

@Nottinghster
Copy link
Contributor

Well, what's missing to be updated or released ?
It's a great plugin/feature and we all miss that :)

@ecogice
Copy link

ecogice commented May 27, 2024

according to aagaming on decky discord you dont need output.name in rollup.config.js, remove the line name: "ControllerTools", in the release candidate and see if that fixes it

@jfernandez
Copy link
Owner

I removed that line from rollup.config.js. Here is the new release candidate. Please give it a try:

controller-tools-1.2.0.zip

@Nottinghster
Copy link
Contributor

I removed that line from rollup.config.js. Here is the new release candidate. Please give it a try:

controller-tools-1.2.0.zip

Now it's working again ❤
screenshot

@ecogice
Copy link

ecogice commented May 27, 2024

yup works :) plugin wasnt showing up when i tried to build manually but all i had to do is delete the settings json for controllertools and reinstall decky

jfernandez added a commit that referenced this issue May 27, 2024
Closes: #43
Signed-off-by: Jose Fernandez <me@jrfernandez.com>
@jfernandez
Copy link
Owner

Thanks for verifying. It looks like there is a small regression with the Refresh button, but since it's cosmetic I'll go ahead and release 1.2.0 with the fix.

jfernandez added a commit that referenced this issue May 27, 2024
Closes: #43
Signed-off-by: Jose Fernandez <me@jrfernandez.com>
jfernandez added a commit to jfernandez/decky-plugin-database that referenced this issue May 27, 2024
Update ControllerTools to v1.2.0 and change the submodule to point to
the new repository. The alphamercury repository is no longer maintained.
You can verify this by going to the old url [1] and verifying that it
redirects to the new url [2].

This new version pulls in the latest dependencies and makes the plugin
use the global DFL to address an error [3] in the UI after the Steam Deck
client update.

[1] https://github.com/alphamercury/ControllerTools
[2] https://github.com/jfernandez/ControllerTools
[3] jfernandez/ControllerTools#43

Signed-off-by: Jose Fernandez <josef@netflix.com>
jfernandez added a commit to jfernandez/decky-plugin-database that referenced this issue May 31, 2024
Update ControllerTools to v1.2.1 and change the submodule to point to
the new repository. The alphamercury repository is no longer maintained.
You can verify this by going to the old url [1] and verifying that it
redirects to the new url [2].

This new version pulls in the latest dependencies and makes the plugin
use the global DFL to address an error [3] in the UI after the Steam Deck
client update.

[1] https://github.com/alphamercury/ControllerTools
[2] https://github.com/jfernandez/ControllerTools
[3] jfernandez/ControllerTools#43

Signed-off-by: Jose Fernandez <josef@netflix.com>
jfernandez added a commit to jfernandez/decky-plugin-database that referenced this issue Jun 13, 2024
Update ControllerTools to v1.2.2 and change the submodule to point to
the new repository. The alphamercury repository is no longer maintained.
You can verify this by going to the old url [1] and verifying that it
redirects to the new url [2].

This new version pulls in the latest dependencies and makes the plugin
use the global DFL to address an error [3] in the UI after the Steam Deck
client update.

[1] https://github.com/alphamercury/ControllerTools
[2] https://github.com/jfernandez/ControllerTools
[3] jfernandez/ControllerTools#43

Signed-off-by: Jose Fernandez <josef@netflix.com>
jfernandez added a commit to jfernandez/decky-plugin-database that referenced this issue Jun 13, 2024
Update ControllerTools to v1.2.2 and change the submodule to point to
the new repository. The alphamercury repository is no longer maintained.
You can verify this by going to the old url [1] and verifying that it
redirects to the new url [2].

This new version pulls in the latest dependencies and makes the plugin
use the global DFL to address an error [3] in the UI after the Steam Deck
client update.

[1] https://github.com/alphamercury/ControllerTools
[2] https://github.com/jfernandez/ControllerTools
[3] jfernandez/ControllerTools#43

Signed-off-by: Jose Fernandez <josef@netflix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants