New exam lessons screen #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvld
suggested changes
Aug 28, 2018
| LessonsViewData( | ||
| id: $0.id, | ||
| title: $0.title, | ||
| subtitle: countLocalizedString( |
There was a problem hiding this comment.
Это pluralize? Уже есть хелпер в /StepicAdaptiveCourse/StringHelper.swift, он не подходит?
There was a problem hiding this comment.
Про такую штуку не знал, попробую.
Stringsdict вроде бы стандарт для таких ситуаций 🤔
|
|
||
| import Foundation | ||
|
|
||
| final class LessonHeaderTableView: UIView { |
There was a problem hiding this comment.
Кмк, это все таки LessonTableHeaderView :)
|
|
||
| override func viewWillTransition(to size: CGSize, with coordinator: UIViewControllerTransitionCoordinator) { | ||
| super.viewWillTransition(to: size, with: coordinator) | ||
| triggerHeaderViewLayoutUpdate() |
There was a problem hiding this comment.
Аналогично тому, что уже обсуждали. Давай тогда использовать здесь координатор.
| tableView.rowHeight = UITableViewAutomaticDimension | ||
| tableView.estimatedRowHeight = appearance.tableViewEstimatedRowHeight | ||
|
|
||
| tableView.tableHeaderView = LessonHeaderTableView.fromNib() as LessonHeaderTableView |
There was a problem hiding this comment.
Можно без указания типов два раза и без optional:
let headerView: LessonHeaderTableView = .fromNib()
headerView.layer.insertSublayer(headerViewGradient, at: 0)
tableView.tableHeaderView = headerView
kvld
approved these changes
Aug 30, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-2006
Описание:
Обновили внешний вид экрана темы.