-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New exam lessons screen #351
Merged
Merged
Changes from 22 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
c0f7095
Remove unnecessary LessonsTableViewController.xib file
ivan-magda c28b97b
Return Guarantee when getting lessons from cache
ivan-magda 0b910a1
layout LessonTableViewCell
ivan-magda d4256d6
Fill cells with the data
ivan-magda 9a17ecc
Localize lesson pages count
ivan-magda 8126973
Refactor move view data building to the view model
ivan-magda 013bce0
Show practice lessons
ivan-magda 11ca257
Navigate to the adaptive screen
ivan-magda 90c4bfe
Add lesson table header view with dynamic height
ivan-magda 78ae07d
Use guard let syntax
ivan-magda 4d36397
Localize lessons view controller title
ivan-magda 989c8a8
Localize topic lessons count
ivan-magda 452448c
Extend LessonsView with updateHeader(title:,subtitle:)
ivan-magda a37b46f
Refactor rename LessonsPresenter->LessonsPresenterProtocol
ivan-magda 44dddb5
Refactor rename LessonsPresenterImpl->LessonsPresenter
ivan-magda 302a1a0
Add table header view gradient
ivan-magda b9c425d
Refactor extract table view estimated row height
ivan-magda 264b6f5
Refactor rename LessonsAssembly->LessonsAssemblyProtocol
ivan-magda d8f33f2
Refactor rename LessonsAssemblyImpl->LessonsAssembly
ivan-magda d85a709
Refactor rename LessonsRouter->LessonsRouterProtocol
ivan-magda ed38cb1
Refactor rename LessonsRouterImpl->LessonsRouter
ivan-magda 578ac2c
Fix tests
ivan-magda 26dc7a1
Use StringHelper for pluralization
ivan-magda b03c32d
Refactor rename LessonHeaderTableView -> LessonTableHeaderView
ivan-magda ab8b242
Up code quality
ivan-magda 71dd5ec
Use coordinator on size class change
ivan-magda 61f1514
merge dev into feature/exam-new-lessons-screen
ivan-magda 515009d
merge dev into feature/exam-new-lessons-screen
ivan-magda b05952c
Merge branch 'dev' into feature/exam-new-lessons-screen
ivan-magda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 0 additions & 33 deletions
33
ExamEGERussian/Sources/PresentationLayer/Lessons/Assembly/LessonsAssemblyImpl.swift
This file was deleted.
Oops, something went wrong.
16 changes: 16 additions & 0 deletions
16
ExamEGERussian/Sources/PresentationLayer/Lessons/Assembly/LessonsAssemblyProtocol.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// | ||
// LessonsAssemblyProtocol.swift | ||
// ExamEGERussian | ||
// | ||
// Created by Ivan Magda on 30/07/2018. | ||
// Copyright © 2018 Alex Karpov. All rights reserved. | ||
// | ||
|
||
import Foundation | ||
|
||
protocol LessonsAssemblyProtocol: class { | ||
func module( | ||
navigationController: UINavigationController, | ||
topicId: String | ||
) -> UIViewController | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Это pluralize? Уже есть хелпер в /StepicAdaptiveCourse/StringHelper.swift, он не подходит?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Про такую штуку не знал, попробую.
Stringsdict вроде бы стандарт для таких ситуаций 🤔